-
Notifications
You must be signed in to change notification settings - Fork 1.4k
guides, specifications: update for PEP 753 #1611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: William Woodruff <[email protected]>
pfmoore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments, but overall LGTM!
Co-authored-by: Paul Moore <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
This reverts commit 5a6c37d.
Signed-off-by: William Woodruff <[email protected]>
|
CI failure looks unrelated (linkcheck seems to be failing due to the current Internet Archive outage). |
willingc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small edits. Thanks @woodruffw.
Co-authored-by: Carol Willing <[email protected]>
|
CI appears to have righted itself, so this should be good to go! |
|
Gentle ping for review! |
|
You have 2 approvals, I think this is ready to go. I can hit the merge button, apparently, but I'm not really an active committer to this repo, so I think it should be one of the guide editors who merges it. |
webknjaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is a first blush at updating the packaging specifications for PEP 753, now that it's been accepted.
Key changes:
Home-pageandDownload-URLhave been marked as deprecated and moved into the deprecated section of the metadata spec.well-known-project-urls.rsthas been added to reflect the core spec/recommendations in PEP 753.(2) reflects the core spec part of the PEP, but I've tweaked the language to make it less "PEP-y" based on how the other PyPA living specs seem to be written. But I'm happy to restructure/rewrite it however others please!
Related tasks that I still need to do:
CC @pfmoore @ncoghlan @di as interested parties 🙂
📚 Documentation preview 📚: https://python-packaging-user-guide--1611.org.readthedocs.build/en/1611/