Skip to content

PEP 396 was reclassifed as Withdrawn #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2024
Merged

PEP 396 was reclassifed as Withdrawn #1620

merged 2 commits into from
Oct 30, 2024

Conversation

@ncoghlan
Copy link
Member

@ncoghlan ncoghlan commented Oct 23, 2024 •
edited by github-actions bot
Loading

@ncoghlan ncoghlan requested a review from webknjaz October 23, 2024 15:02
@ncoghlan
Copy link
Member Author

ncoghlan commented Oct 23, 2024 •
edited
Loading

Since I was posting a PR anyway, I also fixed another bit of technically incorrect wording in my previous PR. Compliance with PEP 440 (or the lack thereof) isn't the most significant reason for avoiding __version__ when reporting external API versions, it's the fact the external API version isn't the module version.

tacaswell
tacaswell approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was on my way here to make the same PR 😄

@webknjaz webknjaz enabled auto-merge October 30, 2024 00:32
webknjaz
webknjaz approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@webknjaz webknjaz added this pull request to the merge queue Oct 30, 2024
Merged via the queue into pypa:main with commit 55995ee Oct 30, 2024
5 checks passed
@ncoghlan ncoghlan deleted the pep-396-status-change branch October 30, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz webknjaz approved these changes

+1 more reviewer

@tacaswell tacaswell tacaswell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ncoghlan @tacaswell @webknjaz