Clarify that the scripts directory is for files only #1673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following astral-sh/uv#9656 and the discussion in the pypa discord (https://discord.com/channels/803025117553754132/837243676814999553/1314391181656064040), add a clarifying sentence that the scripts directory in wheels if for files only. A future specification may want to extend this to "regular files and symlinks", for not it's limited to regular for clear rewrite semantics.
ncoghlan
approved these changes
Dec 8, 2024
Member
|
Thanks! I also added a History note about the clarification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following astral-sh/uv#9656 and the discussion in the pypa discord (https://discord.com/channels/803025117553754132/837243676814999553/1314391181656064040), add a clarifying sentence that the scripts directory in wheels if for files only.
A future specification may want to extend this to "regular files and symlinks", for not it's limited to regular for clear rewrite semantics.
For ecosystem impact, uv errors when the scripts directory contains non-files and #9656 is the first time this error was reported.
CC @charliermarsh @pradyunsg @uranusjr
📚 Documentation preview 📚: https://python-packaging-user-guide--1673.org.readthedocs.build/en/1673/