Make empty specifier set consistent on pre-releases of non PEP-440 versions

Author: notatallshaw

src/packaging/specifiers.py

@@ -1030,8 +1030,8 @@ def filter(
                 return (
                     item
                     for item in iterable
-                    if (version := _coerce_version(item)) is not None
-                    and not version.is_prerelease
+                    if (version := _coerce_version(item)) is None
+                    or not version.is_prerelease
                 )
 
         # Finally if prereleases is None, apply PEP 440 logic:

tests/test_specifiers.py

@@ -768,6 +768,20 @@ def test_specifiers_prereleases(
                 ["invalid", "foobar"],
             ),
             ("!=2.0.*", None, None, ["1.0", "invalid", "2.0.0"], ["1.0", "invalid"]),
+            # Test that !== ignores prereleases parameter for non-PEP 440 versions
+            ("!=1.0", None, True, ["invalid", "foobar"], ["invalid", "foobar"]),
+            ("!=1.0", None, False, ["invalid", "foobar"], ["invalid", "foobar"]),
+            ("!=1.0", True, None, ["invalid", "foobar"], ["invalid", "foobar"]),
+            ("!=1.0", False, None, ["invalid", "foobar"], ["invalid", "foobar"]),
+            ("!=1.0", True, True, ["invalid", "foobar"], ["invalid", "foobar"]),
+            ("!=1.0", False, False, ["invalid", "foobar"], ["invalid", "foobar"]),
+            # Test that === ignores prereleases parameter for non-PEP 440 versions
+            ("===foobar", None, True, ["foobar", "foo"], ["foobar"]),
+            ("===foobar", None, False, ["foobar", "foo"], ["foobar"]),
+            ("===foobar", True, None, ["foobar", "foo"], ["foobar"]),
+            ("===foobar", False, None, ["foobar", "foo"], ["foobar"]),
+            ("===foobar", True, True, ["foobar", "foo"], ["foobar"]),
+            ("===foobar", False, False, ["foobar", "foo"], ["foobar"]),
         ],
     )
     def test_specifier_filter(
@@ -1006,6 +1020,16 @@ def test_empty_specifier(self, version: str) -> None:
         assert parse(version) in spec
         assert spec.contains(parse(version))
 
+    @pytest.mark.parametrize(
+        "prereleases",
+        [None, False, True],
+    )
+    def test_empty_specifier_arbitrary_string(self, prereleases):
+        """Test empty SpecifierSet accepts arbitrary strings."""
+
+        spec = SpecifierSet("", prereleases=prereleases)
+        assert spec.contains("foobar")
+
     def test_create_from_specifiers(self) -> None:
         spec_strs = [">=1.0", "!=1.1", "!=1.2", "<2.0"]
         specs = [Specifier(s) for s in spec_strs]
@@ -1227,13 +1251,13 @@ def test_specifier_contains_installed_prereleases(
             (">=1.0,<=2.0", False, True, ["1.0", "1.5a1"], ["1.0", "1.5a1"]),
             (">=1.0,<=2.0dev", True, False, ["1.0", "1.5a1"], ["1.0"]),
             (">=1.0,<=2.0dev", False, True, ["1.0", "1.5a1"], ["1.0", "1.5a1"]),
-            # Test that invalid versions are discarded
+            # Test that invalid versions are accepted by empty SpecifierSet
             ("", None, None, ["invalid version"], ["invalid version"]),
-            ("", None, False, ["invalid version"], []),
-            ("", False, None, ["invalid version"], []),
+            ("", None, False, ["invalid version"], ["invalid version"]),
+            ("", False, None, ["invalid version"], ["invalid version"]),
             ("", None, None, ["1.0", "invalid version"], ["1.0", "invalid version"]),
-            ("", None, False, ["1.0", "invalid version"], ["1.0"]),
-            ("", False, None, ["1.0", "invalid version"], ["1.0"]),
+            ("", None, False, ["1.0", "invalid version"], ["1.0", "invalid version"]),
+            ("", False, None, ["1.0", "invalid version"], ["1.0", "invalid version"]),
             # Test arbitrary equality (===)
             ("===foobar", None, None, ["foobar", "foo", "bar"], ["foobar"]),
             ("===foobar", None, None, ["foo", "bar"], []),
@@ -1283,6 +1307,20 @@ def test_specifier_contains_installed_prereleases(
                 ["invalid", "1.0", "2.0", "3.0"],
                 ["1.0", "3.0"],
             ),
+            # Test that != ignores prereleases parameter for non-PEP 440 versions
+            ("!=1.0", None, True, ["invalid", "foobar"], ["invalid", "foobar"]),
+            ("!=1.0", None, False, ["invalid", "foobar"], ["invalid", "foobar"]),
+            ("!=1.0", True, None, ["invalid", "foobar"], ["invalid", "foobar"]),
+            ("!=1.0", False, None, ["invalid", "foobar"], ["invalid", "foobar"]),
+            ("!=1.0", True, True, ["invalid", "foobar"], ["invalid", "foobar"]),
+            ("!=1.0", False, False, ["invalid", "foobar"], ["invalid", "foobar"]),
+            # Test that === ignores prereleases parameter for non-PEP 440 versions
+            ("===foobar", None, True, ["foobar", "foo"], ["foobar"]),
+            ("===foobar", None, False, ["foobar", "foo"], ["foobar"]),
+            ("===foobar", True, None, ["foobar", "foo"], ["foobar"]),
+            ("===foobar", False, None, ["foobar", "foo"], ["foobar"]),
+            ("===foobar", True, True, ["foobar", "foo"], ["foobar"]),
+            ("===foobar", False, False, ["foobar", "foo"], ["foobar"]),
         ],
     )
     def test_specifier_filter(