Skip to content

Commit 1e236f4

Browse files
committed
Ignore failing git submodule test for now
Git 2.38.1 patched CVE-2022-39253 by disaling automated fetch against a file: repository. This breaks git submodule, which is used by a pip test. Information on how projects relying on automated fetch should configure git correctly after this change is lacking, so the test is disabled for now until someone can come up with a better solution.
1 parent 36a9b36 commit 1e236f4

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
Git 2.38.1 patched CVE-2022-39253 by disaling automated fetch against a
2+
``file:`` repository. This breaks git submodule, which is used by a pip test.
3+
Information on how projects relying on automated fetch should configure git
4+
correctly after this change is lacking, so the test is disabled for now until
5+
someone can come up with a better solution.

tests/functional/test_install_vcs_git.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -544,6 +544,11 @@ def test_reinstalling_works_with_editable_non_master_branch(
544544

545545
# TODO(pnasrat) fix all helpers to do right things with paths on windows.
546546
@pytest.mark.skipif("sys.platform == 'win32'")
547+
@pytest.mark.xfail(
548+
condition=True,
549+
reason="Git submodule against file: is not working; waiting for a good solution",
550+
run=True,
551+
)
547552
def test_check_submodule_addition(script: PipTestEnvironment) -> None:
548553
"""
549554
Submodules are pulled in on install and updated on upgrade.

0 commit comments

Comments
 (0)