Rewrite regression test

Author: ichard26

tests/functional/test_cli.py

@@ -1,9 +1,13 @@
 """Basic CLI functionality checks.
 """
+import subprocess
+import sys
+from pathlib import Path
 from textwrap import dedent
 
 import pytest
 
+from pip._internal.commands import commands_dict
 from tests.lib import PipTestEnvironment
 
 
@@ -45,3 +49,47 @@ def test_entrypoints_work(entrypoint: str, script: PipTestEnvironment) -> None:
     result2 = script.run("fake_pip", "-V", allow_stderr_warning=True)
     assert result.stdout == result2.stdout
     assert "old script wrapper" in result2.stderr
+
+
+@pytest.mark.parametrize(
+    "command",
+    set(commands_dict).symmetric_difference(
+        # Exclude commands that are expected to use the network.
+        # TODO: uninstall and list should only import network modules as needed
+        {"install", "uninstall", "download", "search", "index", "wheel", "list"}
+    ),
+)
+def test_no_network_imports(command: str, tmp_path: Path) -> None:
+    """
+    Verify that commands that don't access the network do NOT import network code.
+
+    This helps to reduce the startup time of these commands.
+
+    Note: This won't catch lazy network imports, but it'll catch top-level
+    network imports which were accidently added (which is the most likely way
+    to regress anyway).
+    """
+    file = Path(tmp_path, f"imported_modules_for_{command}")
+    code = f"""
+import runpy
+import sys
+
+sys.argv[1:] = [{command!r}, "--help"]
+
+try:
+    runpy.run_module("pip", alter_sys=True, run_name="__main__")
+finally:
+    with open({str(file)!r}, "w") as f:
+        print(*sys.modules.keys(), sep="\\n", file=f)
+    """
+    subprocess.run(
+        [sys.executable],
+        input=code,
+        encoding="utf-8",
+        check=True,
+    )
+    imported = file.read_text().splitlines()
+    assert not any("pip._internal.index" in mod for mod in imported)
+    assert not any("pip._internal.network" in mod for mod in imported)
+    assert not any("requests" in mod for mod in imported)
+    assert not any("urllib3" in mod for mod in imported)

tests/unit/test_commands.py

@@ -1,5 +1,3 @@
-import subprocess
-import sys
 from typing import Callable, List
 from unittest import mock
 
@@ -122,35 +120,3 @@ def is_requirement_command(command: Command) -> bool:
         return isinstance(command, RequirementCommand)
 
     check_commands(is_requirement_command, ["download", "install", "wheel"])
-
-
-@pytest.mark.parametrize(
-    "command", ["cache", "check", "config", "freeze", "hash", "help", "inspect", "show"]
-)
-def test_no_network_imports(command: str) -> None:
-    """
-    Verify that commands that don't access the network do NOT import network code.
-
-    This helps to reduce the startup time of these commands.
-
-    Note: This won't catch lazy network imports, but it'll catch top-level
-    network imports which were accidently added (which is the most likely way
-    to regress anyway).
-    """
-    code = f"""
-import sys
-from pip._internal.commands import create_command
-
-command = create_command("{command}")
-names = sorted(mod.__name__ for mod in sys.modules.values())
-for mod in names:
-    print(mod)
-    """
-    proc = subprocess.run(
-        [sys.executable], encoding="utf-8", input=code, capture_output=True, check=True
-    )
-    imported = proc.stdout.splitlines()
-    assert not any("pip._internal.index" in mod for mod in imported)
-    assert not any("pip._internal.network" in mod for mod in imported)
-    assert not any("requests" in mod for mod in imported)
-    assert not any("urllib3" in mod for mod in imported)