Skip to content

Commit 4aa6d88

Browse files
committed
Remove extra normalization from format_name util
Since this function now always take normalized names, additional normalization is no longer needed.
1 parent d64190c commit 4aa6d88

File tree

1 file changed

+3
-3
lines changed
  • src/pip/_internal/resolution/resolvelib

1 file changed

+3
-3
lines changed

src/pip/_internal/resolution/resolvelib/base.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from typing import FrozenSet, Iterable, Optional, Tuple, Union
22

33
from pip._vendor.packaging.specifiers import SpecifierSet
4-
from pip._vendor.packaging.utils import NormalizedName, canonicalize_name
4+
from pip._vendor.packaging.utils import NormalizedName
55
from pip._vendor.packaging.version import LegacyVersion, Version
66

77
from pip._internal.models.link import Link, links_equivalent
@@ -15,8 +15,8 @@
1515
def format_name(project: NormalizedName, extras: FrozenSet[NormalizedName]) -> str:
1616
if not extras:
1717
return project
18-
canonical_extras = sorted(canonicalize_name(e) for e in extras)
19-
return "{}[{}]".format(project, ",".join(canonical_extras))
18+
extras_expr = ",".join(sorted(extras))
19+
return f"{project}[{extras_expr}]"
2020

2121

2222
class Constraint:

0 commit comments

Comments
 (0)