Merge pull request #10432 from jdufresne/monkeypatch

Remove unused monkeypatch fixtures in tests

Author: pradyunsg

news/cc4b7565-d7c2-4782-a5aa-d5aee715859e.trivial.rst

@@ -126,7 +126,7 @@ def test_skip_invalid_wheel_link(self, caplog, data):
 
         assert "Skipping link: invalid wheel filename:" in caplog.text
 
-    def test_not_find_wheel_not_supported(self, data, monkeypatch):
+    def test_not_find_wheel_not_supported(self, data):
         """
         Test not finding an unsupported wheel.
         """

tests/unit/test_finder.py

@@ -82,7 +82,7 @@ def get_mock_getpwuid(self, uid):
 
 
 class TestDistutilsScheme:
-    def test_root_modifies_appropriately(self, monkeypatch):
+    def test_root_modifies_appropriately(self):
         # This deals with nt/posix path differences
         # root is c:\somewhere\else or /somewhere/else
         root = os.path.normcase(

tests/unit/test_locations.py

@@ -182,7 +182,7 @@ def test_unpack_url_no_download(self, tmpdir, data):
         assert os.path.isdir(os.path.join(self.build_dir, "simple"))
         assert not os.path.isfile(os.path.join(self.download_dir, self.dist_file))
 
-    def test_unpack_url_bad_hash(self, tmpdir, data, monkeypatch):
+    def test_unpack_url_bad_hash(self, tmpdir, data):
         """
         Test when the file url hash fragment is wrong
         """

tests/unit/test_operations_prepare.py

@@ -475,7 +475,7 @@ def test_relative_local_nested_req_files(self, session, monkeypatch, tmpdir):
         assert reqs[0].name == req_name
         assert not reqs[0].constraint
 
-    def test_absolute_local_nested_req_files(self, session, monkeypatch, tmpdir):
+    def test_absolute_local_nested_req_files(self, session, tmpdir):
         """
         Test an absolute nested req file path
         """

tests/unit/test_req_file.py

@@ -87,7 +87,7 @@ def test_make_subprocess_output_error__non_ascii_command_arg(monkeypatch):
     assert actual == expected, f"actual: {actual}"
 
 
-def test_make_subprocess_output_error__non_ascii_cwd_python_3(monkeypatch):
+def test_make_subprocess_output_error__non_ascii_cwd_python_3():
     """
     Test a str (text) cwd with a non-ascii character in Python 3.
     """