Skip to content

Commit 59dbbba

Browse files
committed
Use RequirementsFileParserError instead of RecursionError
1 parent ed63b3d commit 59dbbba

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

src/pip/_internal/req/req_file.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ def _parse_and_recurse(
371371
if initial_file is not None
372372
else ""
373373
)
374-
raise RecursionError(
374+
raise RequirementsFileParseError(
375375
f"{req_path} recursively references itself in {filename} {tail}"
376376
)
377377
# Keeping a track where was each file first included in

tests/unit/test_req_file.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
import pytest
1111

12-
import pip._internal.exceptions
1312
import pip._internal.req.req_file # this will be monkeypatched
1413
from pip._internal.exceptions import InstallationError, RequirementsFileParseError
1514
from pip._internal.index.package_finder import PackageFinder
@@ -364,7 +363,7 @@ def test_recursive_requirements_file(
364363

365364
# When the passed requirements file recursively references itself
366365
with pytest.raises(
367-
RecursionError,
366+
RequirementsFileParseError,
368367
match=(
369368
f"{path_to_string(req_files[0])} recursively references itself"
370369
f" in {path_to_string(req_files[req_file_count - 1])}"
@@ -378,7 +377,7 @@ def test_recursive_requirements_file(
378377
f"-r {req_files[req_file_count - 2].name}"
379378
)
380379
with pytest.raises(
381-
RecursionError,
380+
RequirementsFileParseError,
382381
match=(
383382
f"{path_to_string(req_files[req_file_count - 2])} recursively"
384383
" references itself in"
@@ -401,7 +400,7 @@ def test_recursive_relative_requirements_file(
401400
level_2_req_file.write_text("-r ../../root.txt")
402401

403402
with pytest.raises(
404-
RecursionError,
403+
RequirementsFileParseError,
405404
match=(
406405
f"{path_to_string(root_req_file)} recursively references itself in"
407406
f" {path_to_string(level_2_req_file)}"

0 commit comments

Comments
 (0)