Merge pull request #9773 from sbidoul/fix-pre-commit-ci

Author: uranusjr

.github/workflows/ci.yml

@@ -43,7 +43,7 @@ jobs:
       - uses: actions/setup-python@v2
       - uses: pre-commit/[email protected]
         with:
-          extra_args: --hook-stage=manual
+          extra_args: --all-files --hook-stage=manual
 
   packaging:
     name: packaging

docs/pip_sphinxext.py

@@ -5,7 +5,7 @@
 import re
 import sys
 from textwrap import dedent
-from typing import Iterable, List, Optional
+from typing import Iterable, Iterator, List, Optional
 
 from docutils import nodes, statemachine
 from docutils.parsers import rst
@@ -20,7 +20,9 @@
 class PipNewsInclude(rst.Directive):
     required_arguments = 1
 
-    def _is_version_section_title_underline(self, prev, curr):
+    def _is_version_section_title_underline(
+        self, prev: Optional[str], curr: str
+    ) -> bool:
         """Find a ==== line that marks the version section title."""
         if prev is None:
             return False
@@ -30,7 +32,7 @@ def _is_version_section_title_underline(self, prev, curr):
             return False
         return True
 
-    def _iter_lines_with_refs(self, lines):
+    def _iter_lines_with_refs(self, lines: Iterable[str]) -> Iterator[str]:
         """Transform the input lines to add a ref before each section title.
 
         This is done by looking one line ahead and locate a title's underline,
@@ -44,6 +46,7 @@ def _iter_lines_with_refs(self, lines):
         for line in lines:
             # Transform the previous line to include an explicit ref.
             if self._is_version_section_title_underline(prev, line):
+                assert prev is not None
                 vref = prev.split(None, 1)[0].replace(".", "-")
                 yield f".. _`v{vref}`:"
                 yield ""  # Empty line between ref and the title.
@@ -53,7 +56,7 @@ def _iter_lines_with_refs(self, lines):
         if prev is not None:
             yield prev
 
-    def run(self):
+    def run(self) -> List[nodes.Node]:
         source = self.state_machine.input_lines.source(
             self.lineno - self.state_machine.input_offset - 1,
         )

news/9748.feature.rst

@@ -1 +1 @@
-Improve performance when picking the best file from indexes during `pip install`.
+Improve performance when picking the best file from indexes during ``pip install``.

src/pip/_internal/models/wheel.py

@@ -2,7 +2,7 @@
 name that have meaning.
 """
 import re
-from typing import Dict, List
+from typing import Dict, Iterable, List
 
 from pip._vendor.packaging.tags import Tag
 
@@ -82,7 +82,9 @@ def find_most_preferred_tag(self, tags, tag_to_priority):
         :raises ValueError: If none of the wheel's file tags match one of
             the supported tags.
         """
-        return min(tag_to_priority[tag] for tag in self.file_tags if tag in tag_to_priority)
+        return min(
+            tag_to_priority[tag] for tag in self.file_tags if tag in tag_to_priority
+        )
 
     def supported(self, tags):
         # type: (Iterable[Tag]) -> bool