Skip to content

Commit 79a91ab

Browse files
committed
Guard requests imports in exceptions.py under TYPE_CHECKING
Running `pip show packaging` now results in 420 entries in sys.modules instead of 607.
1 parent fb5f63f commit 79a91ab

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/pip/_internal/exceptions.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,15 @@
1515
from itertools import chain, groupby, repeat
1616
from typing import TYPE_CHECKING, Dict, Iterator, List, Literal, Optional, Union
1717

18-
from pip._vendor.requests.models import Request, Response
1918
from pip._vendor.rich.console import Console, ConsoleOptions, RenderResult
2019
from pip._vendor.rich.markup import escape
2120
from pip._vendor.rich.text import Text
2221

2322
if TYPE_CHECKING:
2423
from hashlib import _Hash
2524

25+
from pip._vendor.requests.models import Request, Response
26+
2627
from pip._internal.metadata import BaseDistribution
2728
from pip._internal.req.req_install import InstallRequirement
2829

@@ -293,8 +294,8 @@ class NetworkConnectionError(PipError):
293294
def __init__(
294295
self,
295296
error_msg: str,
296-
response: Optional[Response] = None,
297-
request: Optional[Request] = None,
297+
response: Optional["Response"] = None,
298+
request: Optional["Request"] = None,
298299
) -> None:
299300
"""
300301
Initialize NetworkConnectionError with `request` and `response`

0 commit comments

Comments
 (0)