Skip to content

Commit 82bda8c

Browse files
committed
Respond to review comments
1 parent abb2a4c commit 82bda8c

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ distlib = "https://bitbucket.org/pypa/distlib/raw/master/LICENSE.txt"
151151
#
152152

153153
[tool.ruff]
154+
# Pinned to delay pyupgrade changes (https://github.com/pypa/pip/issues/13236)
154155
target-version = "py38" # Pin Ruff to Python 3.8
155156
src = ["src"]
156157
line-length = 88

tests/functional/test_uninstall_user.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def test_uninstall_from_usersite_with_dist_in_global_site(
7979
@pytest.mark.xfail(
8080
sys.platform == "darwin"
8181
and platform.machine() == "arm64"
82-
and sys.version_info[:2] == (3, 9),
82+
and sys.version_info[:2] < (3, 10),
8383
reason="Unexpected egg-link install path",
8484
)
8585
def test_uninstall_editable_from_usersite(

tests/lib/compat.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import contextlib
44
import signal
5-
from typing import Callable, ContextManager, Iterable, Iterator
5+
from typing import Callable, ContextManager, Iterator
66

77
# Applies on Windows.
88
if not hasattr(signal, "pthread_sigmask"):
@@ -14,9 +14,6 @@
1414
@contextlib.contextmanager
1515
def blocked_signals() -> Iterator[None]:
1616
"""Block all signals for e.g. starting a worker thread."""
17-
# valid_signals() was added in Python 3.8 (and not using it results
18-
# in a warning on pthread_sigmask() call)
19-
mask: Iterable[int]
2017
mask = signal.valid_signals()
2118

2219
old_mask = signal.pthread_sigmask( # type: ignore[attr-defined]

0 commit comments

Comments
 (0)