Skip to content

Commit 857df90

Browse files
committed
Add maintenance comment
1 parent f39d386 commit 857df90

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/pip/_internal/wheel_builder.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,11 @@ def _should_build(
8383

8484
assert check_bdist_wheel is not None
8585
if not check_bdist_wheel(req):
86+
# /!\ When we change this to unconditionally return True, we must also remove
87+
# support for `--install-option`. Indeed, `--install-option` implies
88+
# `--no-binary` so we can return False here and run `setup.py install`.
89+
# `--global-option` and `--build-option` can remain until we drop support for
90+
# building with `setup.py bdist_wheel`.
8691
req.legacy_install_reason = LegacyInstallReasonNoBinaryForcesSetuptoolsInstall
8792
return False
8893

0 commit comments

Comments
 (0)