Skip to content

Commit 90db7b6

Browse files
authored
Merge pull request #11654 from pradyunsg/replace-pep517-with-pyproject-hooks
2 parents fb02491 + 4162f28 commit 90db7b6

27 files changed

+152
-899
lines changed

news/pep517.vendor.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Remove pep517 from vendored packages

news/pyproject-hooks.vendor.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Add pyproject-hooks 1.0.0

src/pip/_internal/commands/debug.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def create_vendor_txt_map() -> Dict[str, str]:
4848

4949
def get_module_from_module_name(module_name: str) -> ModuleType:
5050
# Module name can be uppercase in vendor.txt for some reason...
51-
module_name = module_name.lower()
51+
module_name = module_name.lower().replace("-", "_")
5252
# PATCH: setuptools is actually only pkg_resources.
5353
if module_name == "setuptools":
5454
module_name = "pkg_resources"

src/pip/_internal/operations/build/metadata.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
import os
55

6-
from pip._vendor.pep517.wrappers import Pep517HookCaller
6+
from pip._vendor.pyproject_hooks import BuildBackendHookCaller
77

88
from pip._internal.build_env import BuildEnvironment
99
from pip._internal.exceptions import (
@@ -15,7 +15,7 @@
1515

1616

1717
def generate_metadata(
18-
build_env: BuildEnvironment, backend: Pep517HookCaller, details: str
18+
build_env: BuildEnvironment, backend: BuildBackendHookCaller, details: str
1919
) -> str:
2020
"""Generate metadata using mechanisms described in PEP 517.
2121
@@ -26,7 +26,7 @@ def generate_metadata(
2626
metadata_dir = metadata_tmpdir.path
2727

2828
with build_env:
29-
# Note that Pep517HookCaller implements a fallback for
29+
# Note that BuildBackendHookCaller implements a fallback for
3030
# prepare_metadata_for_build_wheel, so we don't have to
3131
# consider the possibility that this hook doesn't exist.
3232
runner = runner_with_spinner_message("Preparing metadata (pyproject.toml)")

src/pip/_internal/operations/build/metadata_editable.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
import os
55

6-
from pip._vendor.pep517.wrappers import Pep517HookCaller
6+
from pip._vendor.pyproject_hooks import BuildBackendHookCaller
77

88
from pip._internal.build_env import BuildEnvironment
99
from pip._internal.exceptions import (
@@ -15,7 +15,7 @@
1515

1616

1717
def generate_editable_metadata(
18-
build_env: BuildEnvironment, backend: Pep517HookCaller, details: str
18+
build_env: BuildEnvironment, backend: BuildBackendHookCaller, details: str
1919
) -> str:
2020
"""Generate metadata using mechanisms described in PEP 660.
2121
@@ -26,7 +26,7 @@ def generate_editable_metadata(
2626
metadata_dir = metadata_tmpdir.path
2727

2828
with build_env:
29-
# Note that Pep517HookCaller implements a fallback for
29+
# Note that BuildBackendHookCaller implements a fallback for
3030
# prepare_metadata_for_build_wheel/editable, so we don't have to
3131
# consider the possibility that this hook doesn't exist.
3232
runner = runner_with_spinner_message(

src/pip/_internal/operations/build/wheel.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import os
33
from typing import Optional
44

5-
from pip._vendor.pep517.wrappers import Pep517HookCaller
5+
from pip._vendor.pyproject_hooks import BuildBackendHookCaller
66

77
from pip._internal.utils.subprocess import runner_with_spinner_message
88

@@ -11,7 +11,7 @@
1111

1212
def build_wheel_pep517(
1313
name: str,
14-
backend: Pep517HookCaller,
14+
backend: BuildBackendHookCaller,
1515
metadata_directory: str,
1616
tempd: str,
1717
) -> Optional[str]:

src/pip/_internal/operations/build/wheel_editable.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import os
33
from typing import Optional
44

5-
from pip._vendor.pep517.wrappers import HookMissing, Pep517HookCaller
5+
from pip._vendor.pyproject_hooks import BuildBackendHookCaller, HookMissing
66

77
from pip._internal.utils.subprocess import runner_with_spinner_message
88

@@ -11,7 +11,7 @@
1111

1212
def build_wheel_editable(
1313
name: str,
14-
backend: Pep517HookCaller,
14+
backend: BuildBackendHookCaller,
1515
metadata_directory: str,
1616
tempd: str,
1717
) -> Optional[str]:

src/pip/_internal/req/req_install.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
from pip._vendor.packaging.utils import canonicalize_name
1919
from pip._vendor.packaging.version import Version
2020
from pip._vendor.packaging.version import parse as parse_version
21-
from pip._vendor.pep517.wrappers import Pep517HookCaller
21+
from pip._vendor.pyproject_hooks import BuildBackendHookCaller
2222

2323
from pip._internal.build_env import BuildEnvironment, NoOpBuildEnvironment
2424
from pip._internal.exceptions import InstallationError, LegacyInstallFailure
@@ -51,7 +51,7 @@
5151
)
5252
from pip._internal.utils.hashes import Hashes
5353
from pip._internal.utils.misc import (
54-
ConfiguredPep517HookCaller,
54+
ConfiguredBuildBackendHookCaller,
5555
ask_path_exists,
5656
backup_dir,
5757
display_path,
@@ -173,7 +173,7 @@ def __init__(
173173
self.requirements_to_check: List[str] = []
174174

175175
# The PEP 517 backend we should use to build the project
176-
self.pep517_backend: Optional[Pep517HookCaller] = None
176+
self.pep517_backend: Optional[BuildBackendHookCaller] = None
177177

178178
# Are we using PEP 517 for this requirement?
179179
# After pyproject.toml has been loaded, the only valid values are True
@@ -482,7 +482,7 @@ def load_pyproject_toml(self) -> None:
482482
requires, backend, check, backend_path = pyproject_toml_data
483483
self.requirements_to_check = check
484484
self.pyproject_requires = requires
485-
self.pep517_backend = ConfiguredPep517HookCaller(
485+
self.pep517_backend = ConfiguredBuildBackendHookCaller(
486486
self,
487487
self.unpacked_source_directory,
488488
backend,

src/pip/_internal/utils/misc.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
cast,
3535
)
3636

37-
from pip._vendor.pep517 import Pep517HookCaller
37+
from pip._vendor.pyproject_hooks import BuildBackendHookCaller
3838
from pip._vendor.tenacity import retry, stop_after_delay, wait_fixed
3939

4040
from pip import __version__
@@ -57,7 +57,7 @@
5757
"captured_stdout",
5858
"ensure_dir",
5959
"remove_auth_from_url",
60-
"ConfiguredPep517HookCaller",
60+
"ConfiguredBuildBackendHookCaller",
6161
]
6262

6363

@@ -635,7 +635,7 @@ def partition(
635635
return filterfalse(pred, t1), filter(pred, t2)
636636

637637

638-
class ConfiguredPep517HookCaller(Pep517HookCaller):
638+
class ConfiguredBuildBackendHookCaller(BuildBackendHookCaller):
639639
def __init__(
640640
self,
641641
config_holder: Any,

src/pip/_internal/utils/subprocess.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,8 +239,8 @@ def call_subprocess(
239239
def runner_with_spinner_message(message: str) -> Callable[..., None]:
240240
"""Provide a subprocess_runner that shows a spinner message.
241241
242-
Intended for use with for pep517's Pep517HookCaller. Thus, the runner has
243-
an API that matches what's expected by Pep517HookCaller.subprocess_runner.
242+
Intended for use with for BuildBackendHookCaller. Thus, the runner has
243+
an API that matches what's expected by BuildBackendHookCaller.subprocess_runner.
244244
"""
245245

246246
def runner(

0 commit comments

Comments
 (0)