Skip to content

Commit 99bea32

Browse files
committed
Merge branch 'main' into extra-normalization
2 parents c94d81a + 8c24fd2 commit 99bea32

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

tests/functional/test_install_extras.py

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,19 @@ def test_install_fails_if_extra_at_end(
159159
"specified_extra, requested_extra",
160160
[
161161
("Hop_hOp-hoP", "Hop_hOp-hoP"),
162-
("Hop_hOp-hoP", "hop-hop-hop"),
162+
pytest.param(
163+
"Hop_hOp-hoP",
164+
"hop-hop-hop",
165+
marks=pytest.mark.xfail(
166+
"sys.version_info < (3, 8)",
167+
reason=(
168+
"matching a normalized extra request against an"
169+
"unnormalized extra in metadata requires PEP 685 support "
170+
"in either packaging or the build tool. Setuptools "
171+
"implements this in 68.2, which requires 3.8+"
172+
),
173+
),
174+
),
163175
("hop-hop-hop", "Hop_hOp-hoP"),
164176
],
165177
)

tests/requirements-common_wheels.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@
66
# (Adjust artifact directory used based on preference and operating system)
77

88
# Implements new extra normalization.
9-
setuptools >= 68.2
9+
setuptools >= 68.2 ; python_version >= '3.8'
10+
setuptools >= 40.8.0, != 60.6.0 ; python_version < '3.8'
11+
1012
wheel
13+
1114
# As required by pytest-cov.
1215
coverage >= 4.4

0 commit comments

Comments
 (0)