Skip to content

Commit 9f7cb65

Browse files
committed
Run unit tests with no build isolation
Some unit test need to run metadata preparation for setuptools based test projects.
1 parent 60ac406 commit 9f7cb65

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

tests/unit/resolution_resolvelib/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def finder(data: TestData) -> PackageFinder:
3535
def preparer(finder: PackageFinder) -> Iterator[RequirementPreparer]:
3636
session = PipSession()
3737
rc = InstallCommand("x", "y")
38-
o = rc.parse_args([])
38+
o = rc.parse_args(["--no-build-isolation"])
3939

4040
with global_tempdir_manager():
4141
with TempDirectory() as tmp:

tests/unit/test_req.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ def _basic_resolver(
9090
finder: PackageFinder,
9191
require_hashes: bool = False,
9292
wheel_cache: WheelCache | None = None,
93+
build_isolation: bool = True,
9394
) -> Iterator[Resolver]:
9495
make_install_req = partial(
9596
install_req_from_req_string,
@@ -103,7 +104,7 @@ def _basic_resolver(
103104
build_dir=os.path.join(self.tempdir, "build"),
104105
src_dir=os.path.join(self.tempdir, "src"),
105106
download_dir=None,
106-
build_isolation=True,
107+
build_isolation=build_isolation,
107108
build_isolation_installer=installer,
108109
check_build_deps=False,
109110
build_tracker=tracker,
@@ -165,7 +166,7 @@ def test_environment_marker_extras(self, data: TestData) -> None:
165166
req.user_supplied = True
166167
reqset.add_unnamed_requirement(req)
167168
finder = make_test_finder(find_links=[data.find_links])
168-
with self._basic_resolver(finder) as resolver:
169+
with self._basic_resolver(finder, build_isolation=False) as resolver:
169170
reqset = resolver.resolve(reqset.all_requirements, True)
170171
assert not reqset.has_requirement("simple")
171172

@@ -318,7 +319,9 @@ def test_unhashed_deps_on_require_hashes(self, data: TestData) -> None:
318319
)
319320
)
320321

321-
with self._basic_resolver(finder, require_hashes=True) as resolver:
322+
with self._basic_resolver(
323+
finder, require_hashes=True, build_isolation=False
324+
) as resolver:
322325
with pytest.raises(
323326
HashErrors,
324327
match=(
@@ -359,7 +362,7 @@ def test_hashed_deps_on_require_hashes(self) -> None:
359362
def test_download_info_find_links(self, data: TestData) -> None:
360363
"""Test that download_info is set for requirements via find_links."""
361364
finder = make_test_finder(find_links=[data.find_links])
362-
with self._basic_resolver(finder) as resolver:
365+
with self._basic_resolver(finder, build_isolation=False) as resolver:
363366
ireq = get_processed_req_from_line("simple")
364367
reqset = resolver.resolve([ireq], True)
365368
assert len(reqset.all_requirements) == 1
@@ -384,7 +387,7 @@ def test_download_info_index_url(self) -> None:
384387
def test_download_info_web_archive(self) -> None:
385388
"""Test that download_info is set for requirements from a web archive."""
386389
finder = make_test_finder()
387-
with self._basic_resolver(finder) as resolver:
390+
with self._basic_resolver(finder, build_isolation=False) as resolver:
388391
ireq = get_processed_req_from_line(
389392
"pip-test-package @ "
390393
"https://github.com/pypa/pip-test-package/tarball/0.1.1"
@@ -494,7 +497,7 @@ def test_download_info_local_wheel(self, data: TestData) -> None:
494497
def test_download_info_local_dir(self, data: TestData) -> None:
495498
"""Test that download_info is set for requirements from a local dir."""
496499
finder = make_test_finder()
497-
with self._basic_resolver(finder) as resolver:
500+
with self._basic_resolver(finder, build_isolation=False) as resolver:
498501
ireq_url = data.packages.joinpath("FSPkg").as_uri()
499502
ireq = get_processed_req_from_line(f"FSPkg @ {ireq_url}")
500503
reqset = resolver.resolve([ireq], True)
@@ -507,7 +510,7 @@ def test_download_info_local_dir(self, data: TestData) -> None:
507510
def test_download_info_local_editable_dir(self, data: TestData) -> None:
508511
"""Test that download_info is set for requirements from a local editable dir."""
509512
finder = make_test_finder()
510-
with self._basic_resolver(finder) as resolver:
513+
with self._basic_resolver(finder, build_isolation=False) as resolver:
511514
ireq_url = data.packages.joinpath("FSPkg").as_uri()
512515
ireq = get_processed_req_from_line(f"-e {ireq_url}#egg=FSPkg")
513516
reqset = resolver.resolve([ireq], True)
@@ -522,7 +525,7 @@ def test_download_info_local_editable_dir(self, data: TestData) -> None:
522525
def test_download_info_vcs(self) -> None:
523526
"""Test that download_info is set for requirements from git."""
524527
finder = make_test_finder()
525-
with self._basic_resolver(finder) as resolver:
528+
with self._basic_resolver(finder, build_isolation=False) as resolver:
526529
ireq = get_processed_req_from_line(
527530
"pip-test-package @ git+https://github.com/pypa/pip-test-package"
528531
)

0 commit comments

Comments
 (0)