Skip to content

Commit a388655

Browse files
sbidoulpradyunsg
authored andcommitted
Update test_install_subprocess_output_handling
1 parent b11e8e4 commit a388655

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

tests/functional/test_install.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1515,12 +1515,18 @@ def test_install_subprocess_output_handling(
15151515
# If the install fails, then we *should* show the output... but only once,
15161516
# even if --verbose is given.
15171517
result = script.pip(*(args + ["--global-option=--fail"]), expect_error=True)
1518-
assert 1 == result.stderr.count("I DIE, I DIE")
1518+
# This error is emitted 3 times:
1519+
# - by setup.py bdist_wheel
1520+
# - by setup.py clean
1521+
# - by setup.py install which is used as fallback when setup.py bdist_wheel failed
1522+
# Before, it failed only once because it attempted only setup.py install.
1523+
# TODO update this when we remove the last setup.py install code path.
1524+
assert 3 == result.stderr.count("I DIE, I DIE")
15191525

15201526
result = script.pip(
15211527
*(args + ["--global-option=--fail", "--verbose"]), expect_error=True
15221528
)
1523-
assert 1 == result.stderr.count("I DIE, I DIE")
1529+
assert 3 == result.stderr.count("I DIE, I DIE")
15241530

15251531

15261532
def test_install_log(script: PipTestEnvironment, data: TestData, tmpdir: Path) -> None:

0 commit comments

Comments
 (0)