Skip to content

Commit ae23fc2

Browse files
committed
fix typing
1 parent 6ea91c8 commit ae23fc2

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/pip/_internal/utils/misc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -734,7 +734,7 @@ def prepare_metadata_for_build_editable(
734734
def merge_config_settings(
735735
reqs_settings: Optional[Dict[str, Union[str, List[str]]]],
736736
cli_settings: Optional[Dict[str, Union[str, List[str]]]],
737-
) -> Dict[str, Union[str, List[str]]]:
737+
) -> Optional[Dict[str, Union[str, List[str]]]]:
738738
if not reqs_settings or not cli_settings:
739739
return reqs_settings or cli_settings
740740

tests/unit/test_utils_misc.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,12 @@
1515
({"foo": "bar"}, {"foo": ["baz"]}, {"foo": ["bar", "baz"]}),
1616
({"foo": "bar"}, None, {"foo": "bar"}),
1717
(None, {"foo": ["bar"]}, {"foo": ["bar"]}),
18+
(None, None, None),
1819
],
1920
)
2021
def test_merge_config_settings(
2122
reqs: Optional[Dict[str, Union[str, List[str]]]],
2223
cli: Optional[Dict[str, Union[str, List[str]]]],
23-
expected: Dict[str, Union[str, List[str]]],
24+
expected: Optional[Dict[str, Union[str, List[str]]]],
2425
) -> None:
2526
assert merge_config_settings(reqs, cli) == expected

0 commit comments

Comments
 (0)