Skip to content

Commit b0bf93f

Browse files
committed
Remove unconditionally skipped test (fails if skip removed)
The test was introduced in f999060 (May 2017) and was unconditionally skipped in 6cf5d7d. It remains skipped to this day. In commit bd850c0, the patched_file method was removed/renamed. So even if the skip were removed, it would fail on the undefined attribute. This was caught via mypy which emits an error due to the missing method.
1 parent 0225b2a commit b0bf93f

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

news/5573eba9-07cc-462e-b9af-261568606c94.trivial.rst

Whitespace-only changes.

tests/functional/test_configuration.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
import re
55
import textwrap
66

7-
import pytest
8-
97
from pip._internal.cli.status_codes import ERROR
108
from pip._internal.configuration import CONFIG_BASENAME, get_configuration_files
119
from tests.lib.configuration_helpers import ConfigurationMixin, kinds
@@ -17,18 +15,6 @@ def test_no_options_passed_should_error(script):
1715

1816

1917
class TestBasicLoading(ConfigurationMixin):
20-
@pytest.mark.skip("Can't modify underlying file for any mode")
21-
def test_reads_file_appropriately(self, script):
22-
contents = """
23-
[test]
24-
hello = 1
25-
"""
26-
27-
with self.patched_file(kinds.USER, contents):
28-
result = script.pip("config", "list")
29-
30-
assert "test.hello=1" in result.stdout
31-
3218
def test_basic_modification_pipeline(self, script):
3319
script.pip("config", "get", "test.blah", expect_error=True)
3420
script.pip("config", "set", "test.blah", "1")

0 commit comments

Comments
 (0)