Merge pull request #12974 from notatallshaw/vendored-and-test-import-groups

Add vendored and test import groups to import sorting

Author: sbidoul

news/12974.trivial.rst

@@ -186,9 +186,19 @@ select = [
 ]
 
 [tool.ruff.lint.isort]
-# Explicitly make tests "first party" as it's not in the "src" directory
-known-first-party = ["tests"]
-known-third-party = ["pip._vendor"]
+section-order = [
+  "future",
+  "standard-library",
+  "third-party",
+  "vendored",
+  "first-party",
+  "tests",
+  "local-folder",
+]
+
+[tool.ruff.lint.isort.sections]
+"vendored" = ["pip._vendor"]
+"tests" = ["tests"]
 
 [tool.ruff.lint.mccabe]
 max-complexity = 33  # default is 10

pyproject.toml

@@ -47,6 +47,7 @@
 from pip import __file__ as pip_location
 from pip._internal.locations import _USE_SYSCONFIG
 from pip._internal.utils.temp_dir import global_tempdir_manager
+
 from tests.lib import (
     DATA_DIR,
     SRC_DIR,

tests/conftest.py

@@ -6,6 +6,7 @@
 import pytest
 
 from pip._internal.build_env import BuildEnvironment, _get_system_sitepackages
+
 from tests.lib import (
     PipTestEnvironment,
     TestPipResult,

tests/functional/test_build_env.py

@@ -9,6 +9,7 @@
 import pytest
 
 from pip._internal.commands import commands_dict
+
 from tests.lib import PipTestEnvironment
 
 

tests/functional/test_cli.py

@@ -5,6 +5,7 @@
 from zipfile import ZipFile
 
 from pip._internal.utils.urls import path_to_url
+
 from tests.lib import PipTestEnvironment, create_basic_sdist_for_package
 
 PYPROJECT_TOML = """\

tests/functional/test_config_settings.py

@@ -6,6 +6,7 @@
 
 from pip._internal.cli.status_codes import ERROR
 from pip._internal.configuration import CONFIG_BASENAME, get_configuration_files
+
 from tests.lib import PipTestEnvironment
 from tests.lib.configuration_helpers import ConfigurationMixin, kinds
 from tests.lib.venv import VirtualEnvironment

tests/functional/test_configuration.py

@@ -2,10 +2,12 @@
 from typing import List
 
 import pytest
+
 from pip._vendor.packaging.version import Version
 
 from pip._internal.commands.debug import create_vendor_txt_map
 from pip._internal.utils import compatibility_tags
+
 from tests.lib import PipTestEnvironment
 
 

tests/functional/test_debug.py

@@ -11,6 +11,7 @@
 
 from pip._internal.cli.status_codes import ERROR
 from pip._internal.utils.urls import path_to_url
+
 from tests.lib import (
     PipTestEnvironment,
     ScriptFactory,

tests/functional/test_download.py

@@ -7,9 +7,11 @@
 from typing import Iterable
 
 import pytest
+
 from pip._vendor.packaging.utils import canonicalize_name
 
 from pip._internal.utils.misc import hash_file
+
 from tests.lib import PipTestEnvironment, TestData, TestPipResult