Ignore all candidates of a version when one has invalid metadata

We do this to avoid needlessly building a sdist when
we have determined that a wheel has invalid metadata.

Author: sbidoul

src/pip/_internal/resolution/resolvelib/factory.py

@@ -235,7 +235,7 @@ def _make_base_candidate_from_link(
                         name=name,
                         version=version,
                     )
-                except (MetadataInconsistent, MetadataInvalid) as e:
+                except MetadataInconsistent as e:
                     logger.info(
                         "Discarding [blue underline]%s[/]: [yellow]%s[reset]",
                         link,

src/pip/_internal/resolution/resolvelib/found_candidates.py

@@ -9,13 +9,18 @@
 """
 
 import functools
+import logging
 from collections.abc import Sequence
 from typing import TYPE_CHECKING, Any, Callable, Iterator, Optional, Set, Tuple
 
 from pip._vendor.packaging.version import _BaseVersion
 
+from pip._internal.exceptions import MetadataInvalid
+
 from .base import Candidate
 
+logger = logging.getLogger(__name__)
+
 IndexCandidateInfo = Tuple[_BaseVersion, Callable[[], Optional[Candidate]]]
 
 if TYPE_CHECKING:
@@ -44,11 +49,25 @@ def _iter_built(infos: Iterator[IndexCandidateInfo]) -> Iterator[Candidate]:
     for version, func in infos:
         if version in versions_found:
             continue
-        candidate = func()
-        if candidate is None:
-            continue
-        yield candidate
-        versions_found.add(version)
+        try:
+            candidate = func()
+        except MetadataInvalid as e:
+            logger.warning(
+                "Ignoring version %s of %s since it has invalid metadata:\n"
+                "%s\n"
+                "Please use pip<24.1 if you need to use this version.",
+                version,
+                e.ireq.name,
+                e,
+            )
+            # Mark version as found to avoid trying other candidates with the same
+            # version, since they most likely have invalid metadata as well.
+            versions_found.add(version)
+        else:
+            if candidate is None:
+                continue
+            yield candidate
+            versions_found.add(version)
 
 
 def _iter_built_with_prepended(

tests/functional/test_invalid_versions_and_specifiers.py

@@ -26,8 +26,17 @@ def test_install_from_index_with_invalid_specifier(
     """
     index_url = data.index_url("require-invalid-version")
     result = script.pip(
-        "install", "--dry-run", "--index-url", index_url, "require-invalid-version"
+        "install",
+        "--dry-run",
+        "--index-url",
+        index_url,
+        "require-invalid-version",
+        allow_stderr_warning=True,
     )
+    assert (
+        "WARNING: Ignoring version 1.0 of require-invalid-version "
+        "since it has invalid metadata"
+    ) in result.stderr
     assert "Would install require-invalid-version-0.1" in result.stdout