Merge pull request #12627 from ichard26/not-a-directory-path

Gracefully skip VCS detection on broken PATH

Author: pradyunsg

news/12567.bugfix.rst

@@ -0,0 +1 @@
+Gracefully skip VCS detection in pip freeze when PATH points to a non-directory path.

src/pip/_internal/vcs/versioncontrol.py

@@ -641,6 +641,8 @@ def run_command(
                 log_failed_cmd=log_failed_cmd,
                 stdout_only=stdout_only,
             )
+        except NotADirectoryError:
+            raise BadCommand(f"Cannot find command {cls.name!r} - invalid PATH")
         except FileNotFoundError:
             # errno.ENOENT = no such file or directory
             # In other words, the VCS executable isn't available

tests/unit/test_vcs.py

@@ -444,8 +444,9 @@ def test_version_control__get_url_rev_and_auth__no_revision(url: str) -> None:
     [
         (FileNotFoundError, r"Cannot find command '{name}'"),
         (PermissionError, r"No permission to execute '{name}'"),
+        (NotADirectoryError, "Cannot find command '{name}' - invalid PATH"),
     ],
-    ids=["FileNotFoundError", "PermissionError"],
+    ids=["FileNotFoundError", "PermissionError", "NotADirectoryError"],
 )
 def test_version_control__run_command__fails(
     vcs_cls: Type[VersionControl], exc_cls: Type[Exception], msg_re: str