Skip to content

Commit fc29515

Browse files
Avoid parsing dist.version twice in a row
dist.version is a property that parses the version string each time, so it's slightly faster to only parse it once.
1 parent 81f6a9f commit fc29515

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/pip/_internal/operations/freeze.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,10 @@ def freeze(
145145

146146

147147
def _format_as_name_version(dist: BaseDistribution) -> str:
148-
if isinstance(dist.version, Version):
149-
return f"{dist.raw_name}=={dist.version}"
150-
return f"{dist.raw_name}==={dist.version}"
148+
dist_version = dist.version
149+
if isinstance(dist_version, Version):
150+
return f"{dist.raw_name}=={dist_version}"
151+
return f"{dist.raw_name}==={dist_version}"
151152

152153

153154
def _get_editable_info(dist: BaseDistribution) -> _EditableInfo:

0 commit comments

Comments
 (0)