Bugfix: Make sure ensure_python() installs Python when conditions are met

Previously, even when PIPENV_YES was set or the user confirmed the installation,
the presence of an unnecessary else statement caused ensure_python() to
exit early without attempting the Python installation.

Author: EpiX-1

pipenv/utils/virtualenv.py

@@ -326,41 +326,35 @@ def abort(msg=""):
             elif not project.s.PIPENV_YES:
                 # Non-interactive session without PIPENV_YES, proceed with installation
                 abort()
-            else:
-                # Tell the user we're installing Python.
-                console.print(
-                    f"[bold]Installing [green]CPython[/green] {version} with {installer.cmd}[/bold]"
-                )
-                console.print("(this may take a few minutes)[bold]...[/bold]")
-                with console.status(
-                    "Installing python...", spinner=project.s.PIPENV_SPINNER
-                ):
-                    try:
-                        c = installer.install(version)
-                    except InstallerError as e:
-                        err.print(
-                            environments.PIPENV_SPINNER_FAIL_TEXT.format("Failed...")
-                        )
-                        err.print("Something went wrong...")
-                        err.print(f"[cyan]{e.err}[/cyan]")
-                    else:
-                        console.print(
-                            environments.PIPENV_SPINNER_OK_TEXT.format("Success!")
-                        )
-                        # Print the results, in a beautiful blue...
-                        err.print(f"[cyan]{c.stdout}[/cyan]")
-                # Find the newly installed Python, hopefully.
-                version = str(version)
-                path_to_python = find_a_system_python(version)
+
+            # Tell the user we're installing Python.
+            console.print(
+                f"[bold]Installing [green]CPython[/green] {version} with {installer.cmd}[/bold]"
+            )
+            console.print("(this may take a few minutes)[bold]...[/bold]")
+            with console.status("Installing python...", spinner=project.s.PIPENV_SPINNER):
                 try:
-                    assert python_version(path_to_python) == version
-                except AssertionError:
-                    err.print(
-                        "[bold][red]Warning:[/red][/bold]"
-                        " The Python you just installed is not available "
-                        "on your [bold]PATH[/bold], apparently."
-                    )
-                    sys.exit(1)
+                    c = installer.install(version)
+                except InstallerError as e:
+                    err.print(environments.PIPENV_SPINNER_FAIL_TEXT.format("Failed..."))
+                    err.print("Something went wrong...")
+                    err.print(f"[cyan]{e.err}[/cyan]")
+                else:
+                    console.print(environments.PIPENV_SPINNER_OK_TEXT.format("Success!"))
+                    # Print the results, in a beautiful blue...
+                    err.print(f"[cyan]{c.stdout}[/cyan]")
+            # Find the newly installed Python, hopefully.
+            version = str(version)
+            path_to_python = find_a_system_python(version)
+            try:
+                assert python_version(path_to_python) == version
+            except AssertionError:
+                err.print(
+                    "[bold][red]Warning:[/red][/bold]"
+                    " The Python you just installed is not available "
+                    "on your [bold]PATH[/bold], apparently."
+                )
+                sys.exit(1)
     return path_to_python