Skip to content

Commit 24c9d75

Browse files
Merge pull request #453 from pypa/bugfix/449-disallow-the-nondot
disallow tags without dot again
2 parents b98770f + 8252f92 commit 24c9d75

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

CHANGELOG.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
v4.1.2
2+
=======
3+
4+
* disallow git tags without dots by default again - #449
5+
16
v4.1.1
27
=======
38

src/setuptools_scm/git.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from .win_py31_compat import samefile
1313

1414

15-
DEFAULT_DESCRIBE = "git describe --dirty --tags --long --match *[0-9]*"
15+
DEFAULT_DESCRIBE = "git describe --dirty --tags --long --match *.*"
1616

1717

1818
class GitWorkdir(object):

testing/test_git.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,7 @@ def test_not_matching_tags(wd):
254254

255255

256256
@pytest.mark.issue("https://github.com/pypa/setuptools_scm/issues/411")
257+
@pytest.mark.xfail(reason="https://github.com/pypa/setuptools_scm/issues/449")
257258
def test_non_dotted_version(wd):
258259
wd.commit_testfile()
259260
wd("git tag apache-arrow-1")

0 commit comments

Comments
 (0)