Skip to content

Commit 58e1f22

Browse files
Merge pull request #102 from anarcat/pretend-write
properly write version file even if in pretend mode
2 parents cf19a20 + 80565e3 commit 58e1f22

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

setuptools_scm/__init__.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -104,15 +104,15 @@ def get_version(root='.',
104104
version = _do_parse(root, parse)
105105

106106
if version:
107+
dump_version(
108+
root=root,
109+
version=version,
110+
write_to=write_to,
111+
template=write_to_template)
107112
if isinstance(version, string_types):
108113
return version
109114
version = format_version(
110115
version,
111116
version_scheme=version_scheme,
112117
local_scheme=local_scheme)
113-
dump_version(
114-
root=root,
115-
version=version,
116-
write_to=write_to,
117-
template=write_to_template)
118118
return version

testing/test_functions.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import pytest
22
import pkg_resources
3-
from setuptools_scm import dump_version
3+
from setuptools_scm import dump_version, get_version, PRETEND_KEY
44
from setuptools_scm.version import guess_next_version, meta, format_version
55

66

@@ -56,3 +56,9 @@ def test_dump_version_doesnt_bail_on_value_error(tmpdir):
5656
with pytest.raises(ValueError) as exc_info:
5757
dump_version(tmpdir.strpath, version, write_to)
5858
assert str(exc_info.value).startswith("bad file format:")
59+
60+
61+
def test_dump_version_works_with_pretend(tmpdir, monkeypatch):
62+
monkeypatch.setenv(PRETEND_KEY, '1.0')
63+
get_version(write_to=str(tmpdir.join('VERSION.txt')))
64+
assert tmpdir.join('VERSION.txt').read() == '1.0'

0 commit comments

Comments
 (0)