Merge pull request #382 from RonnyPfannschmidt/check-381

fix #381 - clean out env vars from the git hook system

Author: RonnyPfannschmidt

CHANGELOG.rst

@@ -6,6 +6,8 @@ v3.4.0
 
 * fix #305 - ensure the git file finder closes filedescriptors even when errors happen
 
+* fix #381 - clean out env vars from the git hook system to ensure correct function from within
+
 v3.3.3
 ======
 

MANIFEST.in

@@ -8,3 +8,4 @@ include tox.ini
 include *.rst
 include LICENSE
 include *.toml
+recursive-include testing *.bash

src/setuptools_scm/utils.py

@@ -20,6 +20,27 @@
 string_types = (str,) if PY3 else (str, unicode)  # noqa
 
 
+def no_git_env(env):
+    # adapted from pre-commit
+    # Too many bugs dealing with environment variables and GIT:
+    # https://github.com/pre-commit/pre-commit/issues/300
+    # In git 2.6.3 (maybe others), git exports GIT_WORK_TREE while running
+    # pre-commit hooks
+    # In git 1.9.1 (maybe others), git exports GIT_DIR and GIT_INDEX_FILE
+    # while running pre-commit hooks in submodules.
+    # GIT_DIR: Causes git clone to clone wrong thing
+    # GIT_INDEX_FILE: Causes 'error invalid object ...' during commit
+    for k, v in env.items():
+        if k.startswith("GIT_"):
+            trace(k, v)
+    return {
+        k: v
+        for k, v in env.items()
+        if not k.startswith("GIT_")
+        or k in ("GIT_EXEC_PATH", "GIT_SSH", "GIT_SSH_COMMAND")
+    }
+
+
 def trace(*k):
     if DEBUG:
         print(*k)
@@ -48,15 +69,15 @@ def _always_strings(env_dict):
 
 
 def _popen_pipes(cmd, cwd):
-
     return subprocess.Popen(
         cmd,
         stdout=subprocess.PIPE,
         stderr=subprocess.PIPE,
         cwd=str(cwd),
         env=_always_strings(
             dict(
-                os.environ,
+                no_git_env(os.environ),
+                # os.environ,
                 # try to disable i18n
                 LC_ALL="C",
                 LANGUAGE="",

testing/play_out_381.bash

@@ -0,0 +1,23 @@
+#!/usr/bin/env bash
+set -euxo pipefail
+
+rm -rf y z home venv tmp
+
+[ ! -d black ] && git clone https://github.com/psf/black
+export SETUPTOOLS_SCM_DEBUG=1
+export PRE_COMMIT_HOME="$PWD/home"
+export TMPDIR="$PWD/tmp"
+
+git init y
+git init z
+git -C z commit --allow-empty -m 'commit!'
+git -C y submodule add "$PWD/z"
+cat > "$PWD/y/.git/modules/z/hooks/pre-commit" <<EOF
+#!/usr/bin/env bash
+virtualenv "$PWD/venv"
+"$PWD/venv/bin/pip" install -e "$1"
+"$PWD/venv/bin/pip" install --no-clean "$PWD/black"
+EOF
+chmod +x "$PWD/y/.git/modules/z/hooks/pre-commit"
+cd y/z
+git commit -m "test"

testing/test_git.py

@@ -229,3 +229,14 @@ def test_not_matching_tags(wd):
         tag_regex=r"^apache-arrow-([\.0-9]+)$",
         git_describe_command="git describe --dirty --tags --long --exclude *js* ",
     ).startswith("0.11.2")
+
+
+@pytest.mark.issue("https://github.com/pypa/setuptools_scm/issues/381")
+def test_gitdir(monkeypatch, wd):
+    """
+    """
+    wd.commit_testfile()
+    normal = wd.version
+    # git hooks set this and break subsequent setuptools_scm unless we clean
+    monkeypatch.setenv("GIT_DIR", __file__)
+    assert wd.version == normal