remove the missing section km parameter

Author: RonnyPfannschmidt

src/setuptools_scm/_config.py

@@ -271,30 +271,24 @@ def from_file(
         name: str | os.PathLike[str] = "pyproject.toml",
         dist_name: str | None = None,
         missing_file_ok: bool = False,
-        missing_section_ok: bool = False,
         pyproject_data: PyProjectData | None = None,
         **kwargs: Any,
     ) -> Configuration:
         """
                 Read Configuration from pyproject.toml (or similar).
                 Raises exceptions when file is not found or toml is
-                not installed or the file has invalid format or does
-                not contain setuptools_scm configuration (either via
-        _        [tool.setuptools_scm] section or build-system.requires).
+                not installed or the file has invalid format.
 
         Parameters:
         - name: path to pyproject.toml
         - dist_name: name of the distribution
         - missing_file_ok: if True, do not raise an error if the file is not found
-        - missing_section_ok: if True, do not raise an error if the section is not found
-          (workaround for not walking the dependency graph when figuring out if setuptools_scm is a dependency)
         - **kwargs: additional keyword arguments to pass to the Configuration constructor
         """
 
         if pyproject_data is None:
             pyproject_data = _read_pyproject(
                 Path(name),
-                missing_section_ok=missing_section_ok,
                 missing_file_ok=missing_file_ok,
             )
         args = _get_args_for_pyproject(pyproject_data, dist_name, kwargs)

src/setuptools_scm/_integration/pyproject_reading.py

@@ -114,7 +114,6 @@ def read_pyproject(
     path: Path = Path("pyproject.toml"),
     tool_name: str = "setuptools_scm",
     canonical_build_package_name: str = "setuptools-scm",
-    missing_section_ok: bool = False,
     missing_file_ok: bool = False,
 ) -> PyProjectData:
     try:
@@ -140,21 +139,11 @@ def read_pyproject(
     try:
         section = defn.get("tool", {})[tool_name]
         section_present = True
-    except LookupError as e:
-        if not is_required and not missing_section_ok:
-            # Enhanced error message that mentions both configuration options
-            error = (
-                f"{path} does not contain a tool.{tool_name} section. "
-                f"setuptools_scm requires configuration via either:\n"
-                f"  1. [tool.{tool_name}] section in {path}, or\n"
-                f"  2. {tool_name} (or setuptools-scm) in [build-system] requires"
-            )
-            raise LookupError(error) from e
-        else:
-            error = f"{path} does not contain a tool.{tool_name} section"
-            log.warning("toml section missing %r", error, exc_info=True)
-            section = {}
-            section_present = False
+    except LookupError:
+        error = f"{path} does not contain a tool.{tool_name} section"
+        log.warning("toml section missing %r", error, exc_info=True)
+        section = {}
+        section_present = False
 
     project = defn.get("project", {})
     project_present = "project" in defn

src/setuptools_scm/_integration/setuptools.py

@@ -90,9 +90,7 @@ def version_keyword(
         pyproject_data = _given_pyproject_data
     else:
         try:
-            pyproject_data = read_pyproject(
-                missing_section_ok=True, missing_file_ok=True
-            )
+            pyproject_data = read_pyproject(missing_file_ok=True)
         except (LookupError, ValueError) as e:
             log.debug("Configuration issue in pyproject.toml: %s", e)
             return
@@ -126,7 +124,7 @@ def infer_version(
         pyproject_data = _given_pyproject_data
     else:
         try:
-            pyproject_data = read_pyproject(missing_section_ok=True)
+            pyproject_data = read_pyproject()
         except FileNotFoundError:
             log.debug("pyproject.toml not found, skipping infer_version")
             return

src/setuptools_scm/_integration/version_inference.py

@@ -38,7 +38,6 @@ def apply(self, dist: Any) -> None:
             dist_name=self.dist_name,
             pyproject_data=self.pyproject_data,
             missing_file_ok=True,
-            missing_section_ok=True,
             **(self.overrides or {}),
         )
 

testing/test_integration.py

@@ -881,10 +881,10 @@ def test_build_requires_integration_with_config_reading(wd: WorkDir) -> None:
     assert config.dist_name == "test-package"
 
 
-def test_improved_error_message_mentions_both_config_options(
+def test_missing_section_no_longer_raises_error(
     wd: WorkDir, monkeypatch: pytest.MonkeyPatch
 ) -> None:
-    """Test that the error message mentions both configuration options"""
+    """Test that missing [tool.setuptools_scm] section no longer raises error, creates valid config"""
     if sys.version_info < (3, 11):
         pytest.importorskip("tomli")
 
@@ -904,18 +904,18 @@ def test_improved_error_message_mentions_both_config_options(
 
     from setuptools_scm._config import Configuration
 
-    with pytest.raises(LookupError) as exc_info:
-        Configuration.from_file(
-            name=wd.cwd.joinpath("pyproject.toml"),
-            dist_name="test-package",
-            missing_file_ok=False,
-        )
+    # This should no longer raise an error - instead it should create a valid configuration
+    # with default values and log a warning
+    config = Configuration.from_file(
+        name=wd.cwd.joinpath("pyproject.toml"),
+        dist_name="test-package",
+        missing_file_ok=False,
+    )
 
-    error_msg = str(exc_info.value)
-    # Check that the error message mentions both configuration options
-    assert "tool.setuptools_scm" in error_msg
-    assert "build-system" in error_msg
-    assert "requires" in error_msg
+    # Should have created a valid configuration with default values
+    assert config.dist_name == "test-package"
+    assert config.version_scheme == "guess-next-dev"  # default
+    assert config.local_scheme == "node-and-date"  # default
 
 
 # Helper function for creating and managing distribution objects