Merge pull request #336 from pypa/fix-py38

fix #335 - use signature and add py38 to the matrix

Author: RonnyPfannschmidt

.travis.yml

@@ -22,6 +22,9 @@ python:
 - '3.4'
 - '3.5'
 - '3.6'
+- '3.7'
+- '3.8-dev'
+dist: xenial  # needed for 3.7+
 env:
 - TOXENV=py-test
 

src/setuptools_scm/utils.py

@@ -100,7 +100,8 @@ def function_has_arg(fn, argname):
     if PY2:
         argspec = inspect.getargspec(fn).args
     else:
-        argspec = inspect.getfullargspec(fn).args
+
+        argspec = inspect.signature(fn).parameters
 
     return argname in argspec
 

tox.ini

@@ -1,8 +1,10 @@
 [tox]
-envlist=py{27,34,35,36,37}-test,flake8,check_readme,py{27,37}-selfcheck
+envlist=py{27,34,35,36,37,38}-test,flake8,check_readme,py{27,37}-selfcheck
 
 [pytest]
 filterwarnings=error
+markers=
+    issue(id): reference to github issue
 
 [flake8]
 max-complexity = 10