remove the missing_file_ok hack and use exception handling instead

Author: RonnyPfannschmidt

src/setuptools_scm/_config.py

@@ -270,7 +270,6 @@ def from_file(
         cls,
         name: str | os.PathLike[str] = "pyproject.toml",
         dist_name: str | None = None,
-        missing_file_ok: bool = False,
         pyproject_data: PyProjectData | None = None,
         **kwargs: Any,
     ) -> Configuration:
@@ -282,15 +281,11 @@ def from_file(
         Parameters:
         - name: path to pyproject.toml
         - dist_name: name of the distribution
-        - missing_file_ok: if True, do not raise an error if the file is not found
         - **kwargs: additional keyword arguments to pass to the Configuration constructor
         """
 
         if pyproject_data is None:
-            pyproject_data = _read_pyproject(
-                Path(name),
-                missing_file_ok=missing_file_ok,
-            )
+            pyproject_data = _read_pyproject(Path(name))
         args = _get_args_for_pyproject(pyproject_data, dist_name, kwargs)
 
         args.update(read_toml_overrides(args["dist_name"]))

src/setuptools_scm/_integration/pyproject_reading.py

@@ -126,16 +126,11 @@ def read_pyproject(
     path: Path = Path("pyproject.toml"),
     tool_name: str = "setuptools_scm",
     canonical_build_package_name: str = "setuptools-scm",
-    missing_file_ok: bool = False,
 ) -> PyProjectData:
     try:
         defn = read_toml_content(path)
     except FileNotFoundError:
-        if missing_file_ok:
-            log.warning("File %s not found, using empty configuration", path)
-            return PyProjectData.empty(path=path, tool_name=tool_name)
-        else:
-            raise
+        raise
 
     requires: list[str] = defn.get("build-system", {}).get("requires", [])
     is_required = has_build_package(requires, canonical_build_package_name)

src/setuptools_scm/_integration/setuptools.py

@@ -3,6 +3,7 @@
 import logging
 import warnings
 
+from pathlib import Path
 from typing import Any
 from typing import Callable
 
@@ -90,7 +91,12 @@ def version_keyword(
         pyproject_data = _given_pyproject_data
     else:
         try:
-            pyproject_data = read_pyproject(missing_file_ok=True)
+            pyproject_data = read_pyproject()
+        except FileNotFoundError:
+            log.debug("pyproject.toml not found, proceeding with empty configuration")
+            pyproject_data = PyProjectData.empty(
+                Path("pyproject.toml"), "setuptools_scm"
+            )
         except (LookupError, ValueError) as e:
             log.debug("Configuration issue in pyproject.toml: %s", e)
             return

src/setuptools_scm/_integration/version_inference.py

@@ -37,7 +37,6 @@ def apply(self, dist: Any) -> None:
         config = _config_module.Configuration.from_file(
             dist_name=self.dist_name,
             pyproject_data=self.pyproject_data,
-            missing_file_ok=True,
             **(self.overrides or {}),
         )
 

testing/test_integration.py

@@ -910,7 +910,6 @@ def test_missing_section_no_longer_raises_error(
     config = Configuration.from_file(
         name=wd.cwd.joinpath("pyproject.toml"),
         dist_name="test-package",
-        missing_file_ok=False,
     )
 
     # Should have created a valid configuration with default values

testing/test_pyproject_reading.py

@@ -10,25 +10,10 @@
 class TestPyProjectReading:
     """Test the pyproject reading functionality."""
 
-    def test_read_pyproject_missing_file_ok(self, tmp_path: Path) -> None:
-        """Test that read_pyproject handles missing files when missing_file_ok=True."""
-        # Test with missing_file_ok=True
-        result = read_pyproject(
-            path=tmp_path / "nonexistent.toml", missing_file_ok=True
-        )
-
-        assert result.path == tmp_path / "nonexistent.toml"
-        assert result.tool_name == "setuptools_scm"
-        assert result.project == {}
-        assert result.section == {}
-        assert result.is_required is False
-        assert result.section_present is False
-        assert result.project_present is False
-
-    def test_read_pyproject_missing_file_not_ok(self, tmp_path: Path) -> None:
-        """Test that read_pyproject raises FileNotFoundError when missing_file_ok=False."""
+    def test_read_pyproject_missing_file_raises(self, tmp_path: Path) -> None:
+        """Test that read_pyproject raises FileNotFoundError when file is missing."""
         with pytest.raises(FileNotFoundError):
-            read_pyproject(path=tmp_path / "nonexistent.toml", missing_file_ok=False)
+            read_pyproject(path=tmp_path / "nonexistent.toml")
 
     def test_read_pyproject_existing_file(self, tmp_path: Path) -> None:
         """Test that read_pyproject reads existing files correctly."""