pre-commit

Author: thejcannon

src/setuptools_scm/_config.py

@@ -42,8 +42,8 @@ def _check_tag_regex(value: str | Pattern[str] | None) -> Pattern[str]:
     group_names = regex.groupindex.keys()
     if regex.groups == 0 or (regex.groups > 1 and "version" not in group_names):
         raise ValueError(
-            f"Expected tag_regex '{regex.pattern}' to contain a single match group or a group named"
-            " 'version' to identify the version part of any tag."
+            f"Expected tag_regex '{regex.pattern}' to contain a single match group or"
+            " a group named 'version' to identify the version part of any tag."
         )
 
     return regex
@@ -105,7 +105,7 @@ class Configuration:
 
     parent: _t.PathT | None = None
 
-    def __post_init__(self):
+    def __post_init__(self) -> None:
         self.tag_regex = _check_tag_regex(self.tag_regex)
 
     @property

src/setuptools_scm/_entrypoints.py

@@ -110,7 +110,7 @@ def _call_version_scheme(
     entrypoint: str,
     given_value: _t.VERSION_SCHEMES,
     default: str | None = None,
-) -> str | None:
+) -> str:
     found_any_implementation = False
     for scheme in _iter_version_schemes(entrypoint, given_value):
         found_any_implementation = True
@@ -119,10 +119,12 @@ def _call_version_scheme(
             return result
     if not found_any_implementation:
         raise ValueError(
-            f'Couldn\'t find any implementations for entrypoint "{entrypoint}" with value "{given_value}".'
+            f'Couldn\'t find any implementations for entrypoint "{entrypoint}"'
+            f' with value "{given_value}".'
         )
     if default is not None:
         return default
     raise ValueError(
-        f'None of the "{entrypoint}" entrypoints matching "{given_value}" returned a value.'
+        f'None of the "{entrypoint}" entrypoints matching "{given_value}"'
+        " returned a value."
     )

src/setuptools_scm/version.py

@@ -67,8 +67,8 @@ def _parse_version_tag(
             return result
 
         raise ValueError(
-            f'The tag_regex "{config.tag_regex.pattern}" matched tag "{tag}", however the matched'
-            " group has no value."
+            f'The tag_regex "{config.tag_regex.pattern}" matched tag "{tag}", '
+            "however the matched group has no value."
         )
     else:
         log.debug("tag %r did not parse", tag)

testing/test_config.py

@@ -110,6 +110,10 @@ def test_config_overrides(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> No
 def test_config_bad_regex(tag_regex: str) -> None:
     with pytest.raises(
         ValueError,
-        match=f"Expected tag_regex '{re.escape(tag_regex)}' to contain a single match group or a group named 'version' to identify the version part of any tag.",
+        match=(
+            f"Expected tag_regex '{re.escape(tag_regex)}' to contain a single match"
+            " group or a group named 'version' to identify the version part of any"
+            " tag."
+        ),
     ):
-        Configuration(tag_regex=tag_regex)
+        Configuration(tag_regex=re.compile(tag_regex))

testing/test_version.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import re
 from dataclasses import replace
 from datetime import date
 from datetime import timedelta
@@ -192,9 +193,12 @@ def test_tag_regex1(tag: str, expected: str) -> None:
 def test_regex_match_but_no_version() -> None:
     with pytest.raises(
         ValueError,
-        match=r'The tag_regex "\(\?P<version>\)\.\*" matched tag "v1", however the matched group has no value',
+        match=(
+            r'The tag_regex "\(\?P<version>\)\.\*" matched tag "v1", '
+            " however the matched group has no value"
+        ),
     ):
-        meta("v1", config=replace(c, tag_regex="(?P<version>).*"))
+        meta("v1", config=replace(c, tag_regex=re.compile("(?P<version>).*")))
 
 
 @pytest.mark.issue("https://github.com/pypa/setuptools_scm/issues/471")
@@ -424,11 +428,14 @@ def __repr__(self) -> str:
 def test_no_matching_entrypoints(config_key: str) -> None:
     version = meta(
         "1.0",
-        config=replace(c, **{config_key: "nonexistant"}),
+        config=replace(c, **{config_key: "nonexistant"}),  # type: ignore
     )
     with pytest.raises(
         ValueError,
-        match=r'Couldn\'t find any implementations for entrypoint "setuptools_scm\..*?" with value "nonexistant"',
+        match=(
+            r'Couldn\'t find any implementations for entrypoint "setuptools_scm\..*?"'
+            ' with value "nonexistant"'
+        ),
     ):
         format_version(version)
 
@@ -438,11 +445,14 @@ def test_all_entrypoints_return_none() -> None:
         "1.0",
         config=replace(
             c,
-            version_scheme=lambda v: None,
+            version_scheme=lambda v: None,  # type: ignore
         ),
     )
     with pytest.raises(
         ValueError,
-        match=r'None of the "setuptools_scm.version_scheme" entrypoints matching .*? returned a value.',
+        match=(
+            'None of the "setuptools_scm.version_scheme" entrypoints matching'
+            r" .*? returned a value."
+        ),
     ):
         format_version(version)