remove bad deferred locgic from entrypoint selection

passing concrete objects instead of the boolean makes it way more safe

Author: RonnyPfannschmidt

src/setuptools_scm/_entrypoints.py

@@ -13,8 +13,8 @@
 from . import version
 
 if TYPE_CHECKING:
-    from ._config import Configuration
     from . import _types as _t
+    from ._config import Configuration, ParseFunction
 
 
 log = _log.log.getChild("entrypoints")
@@ -27,21 +27,14 @@ def load(self) -> Any:
         pass
 
 
-def _version_from_entrypoints(
-    config: Configuration, fallback: bool = False
+def version_from_entrypoint(
+    config: Configuration, entrypoint: str, root: _t.PathT
 ) -> version.ScmVersion | None:
-    if fallback:
-        entrypoint = "setuptools_scm.parse_scm_fallback"
-        root = config.fallback_root
-    else:
-        entrypoint = "setuptools_scm.parse_scm"
-        root = config.absolute_root
-
     from .discover import iter_matching_entrypoints
 
     log.debug("version_from_ep %s in %s", entrypoint, root)
     for ep in iter_matching_entrypoints(root, entrypoint, config):
-        fn = ep.load()
+        fn: ParseFunction = ep.load()
         maybe_version: version.ScmVersion | None = fn(root, config=config)
         log.debug("%s found %r", ep, maybe_version)
         if maybe_version is not None:

src/setuptools_scm/_get_version.py

@@ -8,9 +8,9 @@
 from typing import Pattern
 
 from . import _config
+from . import _entrypoints
 from . import _types as _t
 from ._config import Configuration
-from ._entrypoints import _version_from_entrypoints
 from ._overrides import _read_pretended_version_for
 from ._version_cls import _validate_version_cls
 from .version import format_version as _format_version
@@ -27,11 +27,15 @@ def parse_scm_version(config: Configuration) -> ScmVersion | None:
             )
         return parse_result
     else:
-        return _version_from_entrypoints(config)
+        entrypoint = "setuptools_scm.parse_scm"
+        root = config.absolute_root
+        return _entrypoints.version_from_entrypoint(config, entrypoint, root)
 
 
 def parse_fallback_version(config: Configuration) -> ScmVersion | None:
-    return _version_from_entrypoints(config, fallback=True)
+    entrypoint = "setuptools_scm.parse_scm_fallback"
+    root = config.fallback_root
+    return _entrypoints.version_from_entrypoint(config, entrypoint, root)
 
 
 def _do_parse(config: Configuration) -> ScmVersion | None: