From a6814693a742dfcee8cfff31001f088579e85dce Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Mon, 4 Aug 2025 22:17:54 +0200 Subject: [PATCH 1/2] Fix typos found by codespell --- CHANGELOG.md | 6 +++--- testing/test_version.py | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1b952ade..07a07435 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,7 +12,7 @@ ### Breaking -- fix #1019: pass python version build tags from scm version to results propperly +- fix #1019: pass python version build tags from scm version to results properly ### Added @@ -37,7 +37,7 @@ - fix #1150: enable setuptools-scm when we are a build requirement - feature #1154: add the commit id the the default version file template - drop scriv -- fix #921: document setuptools version requirements more consistently - 61 as minumum asn 8 as recommended minimum +- fix #921: document setuptools version requirements more consistently - 61 as minimum asn 8 as recommended minimum ### Fixed @@ -71,7 +71,7 @@ ### Fixed -- fixed #1131: allow self-build without importlib_metadata avaliable on python3.9 +- fixed #1131: allow self-build without importlib_metadata available on python3.9 ## v8.3.0 diff --git a/testing/test_version.py b/testing/test_version.py index 71850074..e63c9493 100644 --- a/testing/test_version.py +++ b/testing/test_version.py @@ -514,13 +514,13 @@ def local(self) -> str | None: def test_no_matching_entrypoints(config_key: str) -> None: version = meta( "1.0", - config=replace(c, **{config_key: "nonexistant"}), # type: ignore[arg-type] + config=replace(c, **{config_key: "nonexistent"}), # type: ignore[arg-type] ) with pytest.raises( ValueError, match=( r'Couldn\'t find any implementations for entrypoint "setuptools_scm\..*?"' - ' with value "nonexistant"' + ' with value "nonexistent"' ), ): format_version(version) From 48e6ed2d2d1ae0054457679185141e5b29d7a04e Mon Sep 17 00:00:00 2001 From: Ronny Pfannschmidt Date: Mon, 4 Aug 2025 23:08:10 +0200 Subject: [PATCH 2/2] add codespell pre-commit hook and correct the missed items --- .cursor/rules/test-running.mdc | 8 +++++--- .pre-commit-config.yaml | 6 ++++++ CHANGELOG.md | 2 +- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/.cursor/rules/test-running.mdc b/.cursor/rules/test-running.mdc index 0bd595a2..dc88f3ea 100644 --- a/.cursor/rules/test-running.mdc +++ b/.cursor/rules/test-running.mdc @@ -1,12 +1,14 @@ --- -description: run tests wit uv tooling +description: run tests with uv tooling globs: alwaysApply: true --- use `uv run pytest` to run tests use uv to manage dependencies - +use `uv run python ...` to run inline tests follow preexisting conventions in the project -- use the fixtures \ No newline at end of file +in cases where a unittest/integration test adds value, prefer adding them first + +- use the fixtures the project defines \ No newline at end of file diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 61fe40d0..34ca0d5e 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -31,3 +31,9 @@ repos: rev: 2025.05.02 hooks: - id: sp-repo-review + +- repo: https://github.com/codespell-project/codespell + rev: v2.3.0 + hooks: + - id: codespell + args: [--ignore-words-list=hist,nd,te] diff --git a/CHANGELOG.md b/CHANGELOG.md index 07a07435..0fadff35 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -50,7 +50,7 @@ - fix #879: add test that validates case different behavior on windows - migrate git describe command to new scm config - add support for failing on missing submodules -- fix #279: expand errors when scm can be found upwards and relative_to wasnt used +- fix #279: expand errors when scm can be found upwards and relative_to wasn't used - fix #577: introduce explicit scmversion node and short node - fix #1100: add workaround for readthedocs worktress to the docs - fix #790: document shallow fail for rtd