Enforce ruff/pyupgrade rule UP031

UP031 Use format specifiers instead of percent format

Author: DimitriPapadopoulos

pkg_resources/__init__.py

@@ -200,7 +200,7 @@ def get_supported_platform():
     m = macosVersionString.match(plat)
     if m is not None and sys.platform == "darwin":
         try:
-            plat = 'macosx-%s-%s' % ('.'.join(_macos_vers()[:2]), m.group(3))
+            plat = 'macosx-{}-{}'.format('.'.join(_macos_vers()[:2]), m.group(3))
         except ValueError:
             # not macOS
             pass
@@ -492,7 +492,7 @@ def compatible_platforms(provided: str | None, required: str | None) -> bool:
             provDarwin = darwinVersionString.match(provided)
             if provDarwin:
                 dversion = int(provDarwin.group(1))
-                macosversion = "%s.%s" % (reqMac.group(1), reqMac.group(2))
+                macosversion = "{}.{}".format(reqMac.group(1), reqMac.group(2))
                 if (
                     dversion == 7
                     and macosversion >= "10.3"
@@ -1316,7 +1316,7 @@ def __iadd__(self, other: Distribution | Environment) -> Self:
                 for dist in other[project]:
                     self.add(dist)
         else:
-            raise TypeError("Can't add %r to environment" % (other,))
+            raise TypeError("Can't add {!r} to environment".format(other))
         return self
 
     def __add__(self, other: Distribution | Environment) -> Self:
@@ -2018,15 +2018,15 @@ def _zipinfo_name(self, fspath):
             return ''
         if fspath.startswith(self.zip_pre):
             return fspath[len(self.zip_pre) :]
-        raise AssertionError("%s is not a subpath of %s" % (fspath, self.zip_pre))
+        raise AssertionError("{} is not a subpath of {}".format(fspath, self.zip_pre))
 
     def _parts(self, zip_path):
         # Convert a zipfile subpath into an egg-relative path part list.
         # pseudo-fs path
         fspath = self.zip_pre + zip_path
         if fspath.startswith(self.egg_root + os.sep):
             return fspath[len(self.egg_root) + 1 :].split(os.sep)
-        raise AssertionError("%s is not a subpath of %s" % (fspath, self.egg_root))
+        raise AssertionError("{} is not a subpath of {}".format(fspath, self.egg_root))
 
     @property
     def zipinfo(self):
@@ -2729,15 +2729,15 @@ def __init__(
         self.dist = dist
 
     def __str__(self) -> str:
-        s = "%s = %s" % (self.name, self.module_name)
+        s = "{} = {}".format(self.name, self.module_name)
         if self.attrs:
             s += ':' + '.'.join(self.attrs)
         if self.extras:
-            s += ' [%s]' % ','.join(self.extras)
+            s += ' [{}]'.format(','.join(self.extras))
         return s
 
     def __repr__(self) -> str:
-        return "EntryPoint.parse(%r)" % str(self)
+        return "EntryPoint.parse({!r})".format(str(self))
 
     @overload
     def load(
@@ -3108,7 +3108,7 @@ def requires(self, extras: Iterable[str] = ()) -> list[Requirement]:
                 deps.extend(dm[safe_extra(ext)])
             except KeyError as e:
                 raise UnknownExtra(
-                    "%s has no such extra feature %r" % (self, ext)
+                    "{} has no such extra feature {!r}".format(self, ext)
                 ) from e
         return deps
 
@@ -3150,7 +3150,7 @@ def activate(self, path: list[str] | None = None, replace: bool = False) -> None
 
     def egg_name(self):
         """Return what this distribution's standard .egg filename should be"""
-        filename = "%s-%s-py%s" % (
+        filename = "{}-{}-py{}".format(
             to_filename(self.project_name),
             to_filename(self.version),
             self.py_version or PY_MAJOR,
@@ -3162,7 +3162,7 @@ def egg_name(self):
 
     def __repr__(self) -> str:
         if self.location:
-            return "%s (%s)" % (self, self.location)
+            return "{} ({})".format(self, self.location)
         else:
             return str(self)
 
@@ -3172,7 +3172,7 @@ def __str__(self) -> str:
         except ValueError:
             version = None
         version = version or "[unknown version]"
-        return "%s %s" % (self.project_name, version)
+        return "{} {}".format(self.project_name, version)
 
     def __getattr__(self, attr: str):
         """Delegate all unrecognized public attributes to .metadata provider"""
@@ -3200,17 +3200,17 @@ def from_filename(
     def as_requirement(self):
         """Return a ``Requirement`` that matches this distribution exactly"""
         if isinstance(self.parsed_version, packaging.version.Version):
-            spec = "%s==%s" % (self.project_name, self.parsed_version)
+            spec = "{}=={}".format(self.project_name, self.parsed_version)
         else:
-            spec = "%s===%s" % (self.project_name, self.parsed_version)
+            spec = "{}==={}".format(self.project_name, self.parsed_version)
 
         return Requirement.parse(spec)
 
     def load_entry_point(self, group: str, name: str) -> _ResolvedEntryPoint:
         """Return the `name` entry point of `group` or raise ImportError"""
         ep = self.get_entry_info(group, name)
         if ep is None:
-            raise ImportError("Entry point %r not found" % ((group, name),))
+            raise ImportError("Entry point {!r} not found".format((group, name)))
         return ep.load()
 
     @overload
@@ -3327,8 +3327,8 @@ def check_version_conflict(self):
             ):
                 continue
             issue_warning(
-                "Module %s was already imported from %s, but %s is being added"
-                " to sys.path" % (modname, fn, self.location),
+                "Module {} was already imported from {}, but {} is being added"
+                " to sys.path".format(modname, fn, self.location),
             )
 
     def has_version(self) -> bool:
@@ -3512,7 +3512,7 @@ def __hash__(self) -> int:
         return self.__hash
 
     def __repr__(self) -> str:
-        return "Requirement.parse(%r)" % str(self)
+        return "Requirement.parse({!r})".format(str(self))
 
     @staticmethod
     def parse(s: str | Iterable[str]) -> Requirement:

ruff.toml

@@ -35,7 +35,6 @@ ignore = [
 	"TRY003", # raise-vanilla-args, avoid multitude of exception classes
 	"TRY301", # raise-within-try, it's handy
 	"UP015", # redundant-open-modes, explicit is preferred
-	"UP031", # temporarily disabled
 	"UP032", # temporarily disabled
 	"UP038", # Using `X | Y` in `isinstance` call is slower and more verbose https://github.com/astral-sh/ruff/issues/7871
 	# Only enforcing return type annotations for public functions

setuptools/__init__.py

@@ -182,7 +182,7 @@ def _ensure_stringlike(self, option, what, default=None):
             return default
         elif not isinstance(val, str):
             raise DistutilsOptionError(
-                "'%s' must be a %s (got `%s`)" % (option, what, val)
+                "'{}' must be a {} (got `{}`)".format(option, what, val)
             )
         return val
 
@@ -210,7 +210,7 @@ def ensure_string_list(self, option: str) -> None:
                 ok = False
             if not ok:
                 raise DistutilsOptionError(
-                    "'%s' must be a list of strings (got %r)" % (option, val)
+                    "'{}' must be a list of strings (got {!r})".format(option, val)
                 )
 
     @overload

setuptools/_core_metadata.py

@@ -150,7 +150,7 @@ def write_pkg_file(self, file):  # noqa: C901  # is too complex (14)  # FIXME
     version = self.get_metadata_version()
 
     def write_field(key, value):
-        file.write("%s: %s\n" % (key, value))
+        file.write("{}: {}\n".format(key, value))
 
     write_field('Metadata-Version', str(version))
     write_field('Name', self.get_name())
@@ -179,7 +179,7 @@ def write_field(key, value):
         write_field('License', rfc822_escape(license))
 
     for project_url in self.project_urls.items():
-        write_field('Project-URL', '%s, %s' % project_url)
+        write_field('Project-URL', '{}, {}'.format(*project_url))
 
     keywords = ','.join(self.get_keywords())
     if keywords:
@@ -209,7 +209,7 @@ def write_field(key, value):
 
     long_description = self.get_long_description()
     if long_description:
-        file.write("\n%s" % long_description)
+        file.write("\n{}".format(long_description))
         if not long_description.endswith("\n"):
             file.write("\n")
 

setuptools/_imp.py

@@ -29,7 +29,7 @@ def find_module(module, paths=None):
     """Just like 'imp.find_module()', but with package support"""
     spec = find_spec(module, paths)
     if spec is None:
-        raise ImportError("Can't find %s" % module)
+        raise ImportError("Can't find {}".format(module))
     if not spec.has_location and hasattr(spec, 'submodule_search_locations'):
         spec = importlib.util.spec_from_loader('__init__.py', spec.loader)
 
@@ -76,12 +76,12 @@ def find_module(module, paths=None):
 def get_frozen_object(module, paths=None):
     spec = find_spec(module, paths)
     if not spec:
-        raise ImportError("Can't find %s" % module)
+        raise ImportError("Can't find {}".format(module))
     return spec.loader.get_code(module)
 
 
 def get_module(module, paths, info):
     spec = find_spec(module, paths)
     if not spec:
-        raise ImportError("Can't find %s" % module)
+        raise ImportError("Can't find {}".format(module))
     return module_from_spec(spec)

setuptools/archive_util.py

@@ -62,7 +62,7 @@ def unpack_archive(
         else:
             return
     else:
-        raise UnrecognizedFormat("Not a recognized archive type: %s" % filename)
+        raise UnrecognizedFormat("Not a recognized archive type: {}".format(filename))
 
 
 def unpack_directory(filename, extract_dir, progress_filter=default_filter) -> None:
@@ -71,7 +71,7 @@ def unpack_directory(filename, extract_dir, progress_filter=default_filter) -> N
     Raises ``UnrecognizedFormat`` if `filename` is not a directory
     """
     if not os.path.isdir(filename):
-        raise UnrecognizedFormat("%s is not a directory" % filename)
+        raise UnrecognizedFormat("{} is not a directory".format(filename))
 
     paths = {
         filename: ('', extract_dir),
@@ -101,7 +101,7 @@ def unpack_zipfile(filename, extract_dir, progress_filter=default_filter) -> Non
     """
 
     if not zipfile.is_zipfile(filename):
-        raise UnrecognizedFormat("%s is not a zip file" % (filename,))
+        raise UnrecognizedFormat("{} is not a zip file".format(filename))
 
     with zipfile.ZipFile(filename) as z:
         _unpack_zipfile_obj(z, extract_dir, progress_filter)
@@ -198,7 +198,7 @@ def unpack_tarfile(filename, extract_dir, progress_filter=default_filter) -> boo
         tarobj = tarfile.open(filename)
     except tarfile.TarError as e:
         raise UnrecognizedFormat(
-            "%s is not a compressed or uncompressed tar file" % (filename,)
+            "{} is not a compressed or uncompressed tar file".format(filename)
         ) from e
 
     for member, final_dst in _iter_open_tar(

setuptools/command/alias.py

@@ -55,7 +55,7 @@ def run(self) -> None:
                 print("setup.py alias", format_alias(alias, aliases))
                 return
             else:
-                print("No alias definition found for %r" % alias)
+                print("No alias definition found for {!r}".format(alias))
                 return
         else:
             alias = self.args[0]
@@ -73,5 +73,5 @@ def format_alias(name, aliases):
     elif source == config_file('local'):
         source = ''
     else:
-        source = '--filename=%r' % source
+        source = '--filename={!r}'.format(source)
     return source + name + ' ' + command

setuptools/command/bdist_egg.py

@@ -263,7 +263,7 @@ def zap_pyfiles(self):
                     pattern = r'(?P<name>.+)\.(?P<magic>[^.]+)\.pyc'
                     m = re.match(pattern, name)
                     path_new = os.path.join(base, os.pardir, m.group('name') + '.pyc')
-                    log.info("Renaming file from [%s] to [%s]" % (path_old, path_new))
+                    log.info("Renaming file from [{}] to [{}]".format(path_old, path_new))
                     try:
                         os.remove(path_new)
                     except OSError:

setuptools/command/build_clib.py

@@ -29,9 +29,9 @@ def build_libraries(self, libraries) -> None:
             sources = build_info.get('sources')
             if sources is None or not isinstance(sources, (list, tuple)):
                 raise DistutilsSetupError(
-                    "in 'libraries' option (library '%s'), "
+                    "in 'libraries' option (library '{}'), "
                     "'sources' must be present and must be "
-                    "a list of source filenames" % lib_name
+                    "a list of source filenames".format(lib_name)
                 )
             sources = sorted(list(sources))
 
@@ -43,9 +43,9 @@ def build_libraries(self, libraries) -> None:
             obj_deps = build_info.get('obj_deps', dict())
             if not isinstance(obj_deps, dict):
                 raise DistutilsSetupError(
-                    "in 'libraries' option (library '%s'), "
+                    "in 'libraries' option (library '{}'), "
                     "'obj_deps' must be a dictionary of "
-                    "type 'source: list'" % lib_name
+                    "type 'source: list'".format(lib_name)
                 )
             dependencies = []
 
@@ -54,9 +54,9 @@ def build_libraries(self, libraries) -> None:
             global_deps = obj_deps.get('', list())
             if not isinstance(global_deps, (list, tuple)):
                 raise DistutilsSetupError(
-                    "in 'libraries' option (library '%s'), "
+                    "in 'libraries' option (library '{}'), "
                     "'obj_deps' must be a dictionary of "
-                    "type 'source: list'" % lib_name
+                    "type 'source: list'".format(lib_name)
                 )
 
             # Build the list to be used by newer_pairwise_group
@@ -67,9 +67,9 @@ def build_libraries(self, libraries) -> None:
                 extra_deps = obj_deps.get(source, list())
                 if not isinstance(extra_deps, (list, tuple)):
                     raise DistutilsSetupError(
-                        "in 'libraries' option (library '%s'), "
+                        "in 'libraries' option (library '{}'), "
                         "'obj_deps' must be a dictionary of "
-                        "type 'source: list'" % lib_name
+                        "type 'source: list'".format(lib_name)
                     )
                 src_deps.extend(extra_deps)
                 dependencies.append(src_deps)

setuptools/command/build_ext.py

@@ -360,7 +360,7 @@ def _write_stub_file(self, stub_file: str, ext: Extension, compile=False):
                     "   global __bootstrap__, __file__, __loader__",
                     "   import sys, os, pkg_resources, importlib.util" + if_dl(", dl"),
                     "   __file__ = pkg_resources.resource_filename"
-                    "(__name__,%r)" % os.path.basename(ext._file_name),
+                    "(__name__,{!r})".format(os.path.basename(ext._file_name)),
                     "   del __bootstrap__",
                     "   if '__loader__' in globals():",
                     "       del __loader__",