Skip to content

Commit 8ff634c

Browse files
committed
Let UniversalCRTSdkDir and NetFxSdkDir return None as before
1 parent d812a3a commit 8ff634c

File tree

1 file changed

+18
-14
lines changed

1 file changed

+18
-14
lines changed

setuptools/msvc.py

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -703,14 +703,14 @@ def FSharpInstallDir(self) -> str:
703703
return self.ri.lookup(path, 'productdir') or ''
704704

705705
@property
706-
def UniversalCRTSdkDir(self) -> str:
706+
def UniversalCRTSdkDir(self) -> str | None:
707707
"""
708708
Microsoft Universal CRT SDK directory.
709709
710710
Return
711711
------
712712
str
713-
path
713+
path | None
714714
"""
715715
# Set Kit Roots versions for specified MSVC++ version
716716
vers = ('10', '81') if self.vs_ver >= 14.0 else ()
@@ -721,10 +721,10 @@ def UniversalCRTSdkDir(self) -> str:
721721
if sdkdir:
722722
return sdkdir
723723

724-
return ''
724+
return None
725725

726726
@property
727-
def UniversalCRTSdkLastVersion(self):
727+
def UniversalCRTSdkLastVersion(self) -> str:
728728
"""
729729
Microsoft Universal C Runtime SDK last version.
730730
@@ -733,7 +733,9 @@ def UniversalCRTSdkLastVersion(self):
733733
str
734734
version
735735
"""
736-
return self._use_last_dir_name(os.path.join(self.UniversalCRTSdkDir, 'lib'))
736+
return self._use_last_dir_name(
737+
os.path.join(self.UniversalCRTSdkDir or '', 'lib')
738+
)
737739

738740
@property
739741
def NetFxSdkVersion(self):
@@ -753,20 +755,22 @@ def NetFxSdkVersion(self):
753755
)
754756

755757
@property
756-
def NetFxSdkDir(self) -> str:
758+
def NetFxSdkDir(self) -> str | None:
757759
"""
758760
Microsoft .NET Framework SDK directory.
759761
760762
Return
761763
------
762-
str
764+
str | None
763765
path
764766
"""
767+
sdkdir: str | None = ''
765768
for ver in self.NetFxSdkVersion:
766769
loc = os.path.join(self.ri.netfx_sdk, ver)
767-
if sdkdir := self.ri.lookup(loc, 'kitsinstallationfolder'):
768-
return sdkdir
769-
return ''
770+
sdkdir = self.ri.lookup(loc, 'kitsinstallationfolder')
771+
if sdkdir:
772+
break
773+
return sdkdir
770774

771775
@property
772776
def FrameworkDir32(self) -> str:
@@ -1345,7 +1349,7 @@ def HTMLHelpWorkshop(self):
13451349
return [os.path.join(self.si.ProgramFilesx86, 'HTML Help Workshop')]
13461350

13471351
@property
1348-
def UCRTLibraries(self):
1352+
def UCRTLibraries(self) -> list[str]:
13491353
"""
13501354
Microsoft Universal C Runtime SDK Libraries.
13511355
@@ -1358,12 +1362,12 @@ def UCRTLibraries(self):
13581362
return []
13591363

13601364
arch_subdir = self.pi.target_dir(x64=True)
1361-
lib = os.path.join(self.si.UniversalCRTSdkDir, 'lib')
1365+
lib = os.path.join(self.si.UniversalCRTSdkDir or '', 'lib')
13621366
ucrtver = self._ucrt_subdir
13631367
return [os.path.join(lib, f'{ucrtver}ucrt{arch_subdir}')]
13641368

13651369
@property
1366-
def UCRTIncludes(self):
1370+
def UCRTIncludes(self) -> list[str]:
13671371
"""
13681372
Microsoft Universal C Runtime SDK Include.
13691373
@@ -1375,7 +1379,7 @@ def UCRTIncludes(self):
13751379
if self.vs_ver < 14.0:
13761380
return []
13771381

1378-
include = os.path.join(self.si.UniversalCRTSdkDir, 'include')
1382+
include = os.path.join(self.si.UniversalCRTSdkDir or '', 'include')
13791383
return [os.path.join(include, f'{self._ucrt_subdir}ucrt')]
13801384

13811385
@property

0 commit comments

Comments
 (0)