Avoid raising exception when license-files is defined outside of pyproject.toml
#4899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cdce8p could you please have a look on this? |
cdce8p
approved these changes
Mar 20, 2025
Member
cdce8p
left a comment
cdce8p
left a comment
There was a problem hiding this comment.
Looks good to me! My intention was to keep the error case from <77. There project.license-files would always raise, so I figured it would be fine to continue to raise if project.license-files is defined simultaneously with tool.setuptools.license-files.
Contributor
Author
|
Thank you very much for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Instead we defer to the follow-up deprecation warning.
Rationale in #4837 (comment)
Pull Request Checklist
newsfragments/.(See documentation for details)