Skip to content

Commit 57db5a7

Browse files
committed
continue 2
1 parent 808f5d1 commit 57db5a7

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/workflows/cibuildwheel.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959
6060
def job(image, os, arch, emulated=False):
6161
matrix.append(dict(
62-
image=image, os=os, arch=arch, needs_emulator=emulated
62+
image=image, os=os, arch=arch, emulated=emulated
6363
))
6464
6565
def linux_job(os, arch, emulated=False, images=images):
@@ -103,7 +103,7 @@ jobs:
103103
fetch-depth: 0
104104

105105
- name: Set up QEMU
106-
if: ${{ matrix.needs_emulator }}
106+
if: ${{ matrix.emulated }}
107107
uses: docker/setup-qemu-action@v3
108108

109109
# Reminder: most configuration is in pyproject.toml so we can use TOML overrides

docs/devel/changelog_staging.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
Android `arm64_v8a`, `armeabi_v7a`, `x86_64`, `x86` and iOS `arm64` device and `arm64`, `x86_64` simulators are now handled in setup and should implicitly download the right pdfium-binaries. Provided on a best effort basis, and largely untested. Testers/feedback welcome.
4848
- pypdfium2's setup is now also capable of producing wheels for these platforms, but they will not actually be included in releases at this time. (Once Termux ships Python 3.13, we may want to publish Android `arm64_v8a` and maybe `armeabi_v7a` wheels, but we do not intend to provide wheels for simulators.)
4949
- iOS will not actually work yet, as the PEP indicates binaries ought to be moved to a special Frameworks location for permission reasons, in which case you'd also have to patch pypdfium2's library search. We cannot do anything about this yet without access to a device or clearer instructions. Community help would be appreciated here.
50+
- Added draft cibuildwheel workflow and configuration, as a second footing for the project (based on the native sourcebuild, see below). In the future, this might allow us to stuff some Linux architecture gaps the *quick & dirty* way with emulation, or maybe new native runners. Many thanks to `wojiushixiaobai` for providing the initial pointers.
5051

5152
*Setup*
5253
- When pdfium binaries are downloaded implicitly on setup or `emplace.py` is run, we now pin the pdfium version by default. This is to prevent possible API breakage when pypdfium2 is installed from source. It should also make the `git` dependency optional on default setup. `update.py` and `craft.py` continue to default to the latest pdfium-binaries version.

0 commit comments

Comments
 (0)