Skip to content

Commit 5d4f312

Browse files
committed
conda.yaml: try to unify "Build package" step
1 parent 8a339a5 commit 5d4f312

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

.github/workflows/conda.yaml

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -73,21 +73,12 @@ jobs:
7373
git config --global user.name "geisserml"
7474
python -m pip install -U -r req/setup.txt
7575
76-
# TODO might be able to unify with ${{ inputs.package == 'raw' && inputs.new_only && '--new-only' || '' }} or something
77-
7876
- name: Build package
79-
if: ${{ inputs.package == 'helpers' || !inputs.new_only }}
80-
run: just craft-conda "$PACKAGE" --pdfium-ver "$PDFIUM_VER"
81-
env:
82-
PACKAGE: ${{ inputs.package }}
83-
PDFIUM_VER: ${{ inputs.pdfium_ver }}
84-
85-
- name: Build package (new only)
86-
if: ${{ inputs.package == 'raw' && inputs.new_only }}
87-
run: just craft-conda "$PACKAGE" --pdfium-ver "$PDFIUM_VER" --new-only
77+
run: just craft-conda "$PACKAGE" --pdfium-ver "$PDFIUM_VER" $MAYBE_NEW_ONLY
8878
env:
8979
PACKAGE: ${{ inputs.package }}
9080
PDFIUM_VER: ${{ inputs.pdfium_ver }}
81+
MAYBE_NEW_ONLY: ${{ inputs.package == 'raw' && inputs.new_only && '--new-only' || '' }}
9182

9283
- name: Upload artifact
9384
uses: actions/upload-artifact@v4
@@ -157,7 +148,7 @@ jobs:
157148

158149
steps:
159150

160-
# FIXME custom channels probably not necessary here
151+
# NOTE custom channels may not be actually necessary here
161152
- name: Miniconda setup
162153
uses: conda-incubator/setup-miniconda@v3
163154
with:

0 commit comments

Comments
 (0)