Skip to content

Commit 06d4dc5

Browse files
authored
xmlrpc: don't call xmlrpc methods twice! (#17712)
1 parent ee1b788 commit 06d4dc5

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

warehouse/legacy/api/xmlrpc/views.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ def faultString(self): # NOQA: ignore=N802
212212
class TypedMapplyViewMapper(MapplyViewMapper):
213213
def mapply(self, fn, args, kwargs):
214214
try:
215-
validate_call(fn)(*args, **kwargs)
215+
return validate_call(fn)(*args, **kwargs)
216216
except ValidationError as exc:
217217
raise XMLRPCInvalidParamTypes(
218218
"; ".join(
@@ -230,8 +230,6 @@ def mapply(self, fn, args, kwargs):
230230
)
231231
)
232232

233-
return super().mapply(fn, args, kwargs)
234-
235233

236234
@view_config(route_name="xmlrpc.pypi", context=Exception, renderer="xmlrpc")
237235
def exception_view(exc, request):

0 commit comments

Comments
 (0)