Skip to content

Commit 1913821

Browse files
authored
chore: remove alt text from sponsor images (#18021)
1 parent 41399c9 commit 1913821

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

tests/unit/sponsors/test_models.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,15 @@
1515

1616
def test_sponsor_color_logo_img_tag(db_request):
1717
sponsor = SponsorFactory.create()
18-
expected = (
19-
f'<img src="{sponsor.color_logo_url}"'
20-
+ f' alt="{sponsor.name}" loading="lazy">'
21-
)
18+
expected = f'<img src="{sponsor.color_logo_url}" alt="" loading="lazy">'
2219
assert sponsor.color_logo_img == expected
2320

2421

2522
def test_sponsor_white_logo_img_tag(db_request):
2623
sponsor = SponsorFactory.create()
2724
expected = (
2825
f'<img class="sponsors__image" src="{sponsor.white_logo_url}"'
29-
+ f' alt="{sponsor.name}" loading="lazy">'
26+
+ ' alt="" loading="lazy">'
3027
)
3128
assert sponsor.white_logo_img == expected
3229

warehouse/sponsors/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,15 @@ class Sponsor(db.Model):
4848

4949
@property
5050
def color_logo_img(self):
51-
return f'<img src="{self.color_logo_url}" alt="{self.name}" loading="lazy">'
51+
return f'<img src="{self.color_logo_url}" alt="" loading="lazy">'
5252

5353
@property
5454
def white_logo_img(self):
5555
if not self.white_logo_url:
5656
return ""
5757
return (
5858
'<img class="sponsors__image" '
59-
+ f'src="{self.white_logo_url}" alt="{self.name}" loading="lazy">'
59+
+ f'src="{self.white_logo_url}" alt="" loading="lazy">'
6060
)
6161

6262
@property

0 commit comments

Comments
 (0)