add hotkeys for organization application review (#17988)

a -> open approve modal
d -> open defer modal
r -> open request more info modal
! -> open decline modal

Author: ewdurbin

warehouse/admin/static/js/warehouse.js

@@ -265,6 +265,36 @@ if (editModalForm !== null) {
   }
 }
 
+$(document).ready(function() {
+  const modalHotKeyBindings = document.querySelectorAll("button[data-hotkey-binding]");
+  var keyBindings = new Map();
+  function bindHotKeys() {
+    document.onkeyup = hotKeys;
+  }
+  function unbindHotKeys() {
+    document.onkeyup = function(){};
+  }
+  function hotKeys(e) {
+    console.log(e);
+    if (keyBindings.has(String(e.which))) {
+      unbindHotKeys();
+      $(keyBindings.get(String(e.which))).modal("show");
+      $(keyBindings.get(String(e.which))).on("hidden.bs.modal", bindHotKeys);
+    }
+  }
+  modalHotKeyBindings.forEach(function(modalHotKeyBinding) {
+    if (! modalHotKeyBinding.disabled) {
+      keyBindings.set(modalHotKeyBinding.dataset.hotkeyBinding, modalHotKeyBinding.dataset.target);
+    }
+  });
+  const inputs = document.querySelectorAll("input");
+  inputs.forEach(function(input) {
+    input.addEventListener("focusin", unbindHotKeys);
+    input.addEventListener("focusout", bindHotKeys);
+  });
+  document.onkeyup = bindHotKeys;
+});
+
 // Link Checking
 const links = document.querySelectorAll("a[data-check-link-url]");
 links.forEach(function(link){

warehouse/admin/templates/admin/organization_applications/detail.html

@@ -64,6 +64,7 @@ <h2 class="card-title">Actions</h2>
               type="button"
               class="btn btn-primary btn-block"
               data-toggle="modal"
+              data-hotkey-binding=65
               data-target="#approveModal" {{ 'disabled' if not request.has_permission(Permissions.AdminOrganizationsWrite) or organization_application.status.value in ['approved', 'declined'] }}
               title="Approve organization request"
             >
@@ -74,6 +75,7 @@ <h2 class="card-title">Actions</h2>
               type="button"
               class="btn btn-info btn-block"
               data-toggle="modal"
+              data-hotkey-binding=82
               data-target="#requestMoreInfoModal" {{ 'disabled' if not request.has_permission(Permissions.AdminOrganizationsWrite) or organization_application.status.value in ['approved', 'declined'] }}
               title="Request more information on this organization request"
             >
@@ -84,6 +86,7 @@ <h2 class="card-title">Actions</h2>
               type="button"
               class="btn btn-danger btn-block"
               data-toggle="modal"
+              data-hotkey-binding=49
               data-target="#declineModal" {{ 'disabled' if not request.has_permission(Permissions.AdminOrganizationsWrite) or organization_application.status.value in ['approved', 'declined'] }}
               title="Decline organization request"
             >
@@ -94,6 +97,7 @@ <h2 class="card-title">Actions</h2>
               type="button"
               class="btn btn-secondary btn-block"
               data-toggle="modal"
+              data-hotkey-binding=68
               data-target="#deferModal" {{ 'disabled' if not request.has_permission(Permissions.AdminOrganizationsWrite) or organization_application.status in ['deferred', 'approved', 'declined'] }}
               title="Defer organization request"
             >
@@ -261,7 +265,7 @@ <h4 class="modal-title" id="requestMoreInfoModalLabel">
                         <label for="requestMoreInfoModalMessage">
                           Message
                         </label>
-                        <textarea id="requestMoreInfoModalMessage" class="form-control" name="message" placeholder="Information you are requesting" rows=16></textarea>
+                        <textarea id="requestMoreInfoModalMessage" class="form-control" name="message" placeholder="Information you are requesting" rows=8></textarea>
                         <span id="requestMoreInfoModalMessageHelpBlock">
                           This message will be included in the notification email.
                         </span>