fix: make event relationship order explicit (#17771)

miketheman · web-flow · commit 69f19a1bd3d1 · 2025-03-13T12:31:11.000-04:00
Without a default order, some pages in Admin may display events in any
order at all by traversing the relationship in a template, making it a
little confusing as to what is most recent.

Existing test `test_recent_events` uses `desc` order today, so preserve
and make explicit.

Signed-off-by: Mike Fiedler &lt;miketheman@gmail.com&gt;
diff --git a/warehouse/events/models.py b/warehouse/events/models.py
@@ -198,6 +198,7 @@ def events(cls):  # noqa: N805
             passive_deletes=True,
             lazy="dynamic",
             back_populates="source",
+            order_by=f"desc({cls.__name__}Event.time)",
         )
 
     def record_event(self, *, tag, request: Request, additional=None):

Original file line number	Diff line number	Diff line change
`@@ -198,6 +198,7 @@ def events(cls): # noqa: N805`
`198`	`198`	`passive_deletes=True,`
`199`	`199`	`lazy="dynamic",`
`200`	`200`	`back_populates="source",`
	`201`	`+ order_by=f"desc({cls.__name__}Event.time)",`
`201`	`202`	`)`
`202`	`203`
`203`	`204`	`def record_event(self, *, tag, request: Request, additional=None):`