Remaining Test Case Fix

Author: dakshbhayana11811137

tests/common/constants.py

@@ -15,13 +15,13 @@
 REMOTE_ADDR = "1.2.3.4"
 
 """
-Static output of `hashlib.sha256(remote_addr.encode("utf8")).hexdigest()`
+Static output of `hashlib.sha256(REMOTE_ADDR.encode("utf8")).hexdigest()`
 Created statically to prevent needing to calculate it every run.
 """
 REMOTE_ADDR_HASHED = "6694f83c9f476da31f5df6bcc520034e7e57d421d247b9d34f49edbfc84a764c"
 
 """
-Output of `hashlib.sha256((remote_addr + "pepa").encode("utf8")).hexdigest()`
+Output of `hashlib.sha256((REMOTE_ADDR + "pepa").encode("utf8")).hexdigest()`
 """
 REMOTE_ADDR_SALTED = "a69a49383d81404e4b1df297c7baa28e1cd6c4ee1495ed5d0ab165a63a147763"
 

tests/unit/ip_addresses/test_models.py

@@ -17,14 +17,15 @@
 
 from warehouse.ip_addresses.models import BanReason
 
+from ...common.constants import REMOTE_ADDR
 from ...common.db.ip_addresses import IpAddressFactory as DBIpAddressFactory
 
 
 class TestIpAddress:
     def test_repr(self, db_request):
         ip_address = db_request.ip_address
         assert isinstance(repr(ip_address), str)
-        assert repr(ip_address) == "1.2.3.4"
+        assert repr(ip_address) == REMOTE_ADDR
 
     def test_invalid_transformed(self, db_request):
         ip_address = DBIpAddressFactory(ip_address="wutang")
@@ -33,21 +34,21 @@ def test_invalid_transformed(self, db_request):
     @pytest.mark.parametrize(
         "kwargs",
         [
-            {"ip_address": "1.2.3.4", "is_banned": True},
+            {"ip_address": REMOTE_ADDR, "is_banned": True},
             {
-                "ip_address": "1.2.3.4",
+                "ip_address": REMOTE_ADDR,
                 "is_banned": True,
                 "ban_reason": BanReason.AUTHENTICATION_ATTEMPTS,
             },
-            {"ip_address": "1.2.3.4", "is_banned": True, "ban_date": sql.func.now()},
+            {"ip_address": REMOTE_ADDR, "is_banned": True, "ban_date": sql.func.now()},
             {
-                "ip_address": "1.2.3.4",
+                "ip_address": REMOTE_ADDR,
                 "is_banned": False,
                 "ban_reason": BanReason.AUTHENTICATION_ATTEMPTS,
             },
-            {"ip_address": "1.2.3.4", "is_banned": False, "ban_date": sql.func.now()},
+            {"ip_address": REMOTE_ADDR, "is_banned": False, "ban_date": sql.func.now()},
             {
-                "ip_address": "1.2.3.4",
+                "ip_address": REMOTE_ADDR,
                 "is_banned": False,
                 "ban_reason": BanReason.AUTHENTICATION_ATTEMPTS,
                 "ban_date": sql.func.now(),