don't n+1 project/role queries on admin.user.detail (#17810)

* don't n+1 project/role queries on admin.user.detail

* add tests, fix logic to show projects with no releases

Author: ewdurbin

tests/unit/admin/views/test_users.py

@@ -149,6 +149,16 @@ def test_gets_user(self, db_request):
         assert result["roles"] == roles
         assert result["emails_form"].emails[0].primary.data
         assert result["submitted_by_journals"] == journal_entries[:5]
+        assert result["user_projects"] == [
+            {
+                "name": project.name,
+                "normalized_name": project.normalized_name,
+                "releases_count": 0,
+                "total_size": 0,
+                "lifecycle_status": None,
+                "role_name": "Owner",
+            }
+        ]
 
     def test_updates_user(self, db_request):
         user = UserFactory.create()

warehouse/admin/templates/admin/users/detail.html

@@ -97,7 +97,7 @@ <h5 class="widget-user-desc text-center">{{ user.name }}</h5>
             </li>
             <li class="nav-item">
               <a href="#projects" class="nav-link">
-                Projects - Total Owned Size	<span class="float-right badge bg-success">{{ roles | selectattr("role_name", "equalto", "Owner") | sum(attribute="project.total_size") | filesizeformat(binary=True) }}</span>
+                Projects - Total Owned Size	<span class="float-right badge bg-success">{{ user_projects | selectattr("role_name", "equalto", "Owner") | sum(attribute="total_size") | filesizeformat(binary=True) }}</span>
               </a>
             </li>
           </ul>
@@ -192,11 +192,11 @@ <h4 class="modal-title" id="nukeModalLabel">Nuke user {{ user.username }}?</h4>
                         This will also delete the following projects and their respective releases:
                       </p>
                       <ul>
-                      {% for project in user.projects %}
+                      {% for project in user_projects %}
                         <li>
                           <a href="{{ request.route_path('admin.project.detail', project_name=project.normalized_name) }}">
                             {{ project.name }}
-                          </a> ({{ project.releases|length }} releases)
+                          </a> ({{ project.releases_count }} releases)
                         </li>
                       {% endfor %}
                       </ul>
@@ -795,11 +795,11 @@ <h3 class="card-title">Projects</h3>
               </tr>
             </thead>
             <tbody>
-            {% for role in roles %}
+            {% for project in user_projects %}
               <tr>
-                <td><a href="{{ request.route_path('admin.project.detail', project_name=role.project.normalized_name) }}">{{ role.project.name }}</a></td>
-                <td>{{ role.role_name }}</td>
-                <td>{{ role.project.total_size | filesizeformat(binary=True) }}</td>
+                <td><a href="{{ request.route_path('admin.project.detail', project_name=project.normalized_name) }}">{{ project.name }}</a></td>
+                <td>{{ project.role_name }}</td>
+                <td>{{ project.total_size | filesizeformat(binary=True) }}</td>
               </tr>
             {% endfor %}
             </tbody>

warehouse/admin/views/users.py

@@ -23,7 +23,7 @@
 from paginate_sqlalchemy import SqlalchemyOrmPage as SQLAlchemyORMPage
 from pyramid.httpexceptions import HTTPBadRequest, HTTPMovedPermanently, HTTPSeeOther
 from pyramid.view import view_config
-from sqlalchemy import or_, select
+from sqlalchemy import func, or_, select
 from sqlalchemy.orm import joinedload
 
 from warehouse.accounts.interfaces import (
@@ -45,7 +45,7 @@
     send_password_reset_by_admin_email,
 )
 from warehouse.observations.models import ObservationKind
-from warehouse.packaging.models import JournalEntry, Project, Role
+from warehouse.packaging.models import JournalEntry, Project, Release, Role
 from warehouse.utils.paginate import paginate_url_factory
 
 
@@ -185,8 +185,45 @@ def user_detail(user, request):
         .all()
     )
 
+    stmt = (
+        select(
+            Project.name,
+            Project.normalized_name,
+            Project.lifecycle_status,
+            Project.total_size,
+            Role.role_name,
+            func.count(Release.id),
+        )
+        .join(Role, Project.id == Role.project_id)
+        .outerjoin(Release, Project.id == Release.project_id)
+        .where(Role.user_id == user.id)
+        .group_by(
+            Project.name,
+            Project.normalized_name,
+            Project.lifecycle_status,
+            Project.total_size,
+            Role.role_name,
+        )
+        .order_by(Project.normalized_name.asc())
+    )
+
+    user_projects = []
+
+    for row in request.db.execute(stmt):
+        project = {
+            "name": row.name,
+            "normalized_name": row.normalized_name,
+            "lifecycle_status": row.lifecycle_status,
+            "total_size": row.total_size,
+            "role_name": row.role_name,
+            "releases_count": row.count,
+        }
+
+        user_projects.append(project)
+
     return {
         "user": user,
+        "user_projects": user_projects,
         "form": form,
         "emails_form": emails_form,
         "roles": roles,