Skip to content

Commit d098d3e

Browse files
Reformat and Linting
1 parent 2ccb5bf commit d098d3e

File tree

10 files changed

+49
-60
lines changed

10 files changed

+49
-60
lines changed

tests/common/constants.py

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -7,33 +7,33 @@
77
REMOTE_ADDR_SALTED = "a69a49383d81404e4b1df297c7baa28e1cd6c4ee1495ed5d0ab165a63a147763"
88

99
DUMMY_GITHUB_OIDC_JWT = (
10-
"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJqdGkiOiI2ZTY3YjFjYi0yYjhkLTRiZ"
11-
"TUtOTFjYi03NTdlZGIyZWM5NzAiLCJzdWIiOiJyZXBvOmZvby9iYXIiLCJhdWQiOiJweXB"
12-
"pIiwicmVmIjoiZmFrZSIsInNoYSI6ImZha2UiLCJyZXBvc2l0b3J5IjoiZm9vL2JhciIsI"
13-
"nJlcG9zaXRvcnlfb3duZXIiOiJmb28iLCJyZXBvc2l0b3J5X293bmVyX2lkIjoiMTIzIiw"
14-
"icnVuX2lkIjoiZmFrZSIsInJ1bl9udW1iZXIiOiJmYWtlIiwicnVuX2F0dGVtcHQiOiIxI"
15-
"iwicmVwb3NpdG9yeV9pZCI6ImZha2UiLCJhY3Rvcl9pZCI6ImZha2UiLCJhY3RvciI6ImZ"
16-
"vbyIsIndvcmtmbG93IjoiZmFrZSIsImhlYWRfcmVmIjoiZmFrZSIsImJhc2VfcmVmIjoiZ"
17-
"mFrZSIsImV2ZW50X25hbWUiOiJmYWtlIiwicmVmX3R5cGUiOiJmYWtlIiwiZW52aXJvbm1"
18-
"lbnQiOiJmYWtlIiwiam9iX3dvcmtmbG93X3JlZiI6ImZvby9iYXIvLmdpdGh1Yi93b3JrZ"
19-
"mxvd3MvZXhhbXBsZS55bWxAZmFrZSIsImlzcyI6Imh0dHBzOi8vdG9rZW4uYWN0aW9ucy5"
20-
"naXRodWJ1c2VyY29udGVudC5jb20iLCJuYmYiOjE2NTA2NjMyNjUsImV4cCI6MTY1MDY2N"
21-
"DE2NSwiaWF0IjoxNjUwNjYzODY1fQ.f-FMv5FF5sdxAWeUilYDt9NoE7Et0vbdNhK32c2o"
22-
"C-E"
23-
)
10+
"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJqdGkiOiI2ZTY3YjFjYi0yYjhkLTRiZ"
11+
"TUtOTFjYi03NTdlZGIyZWM5NzAiLCJzdWIiOiJyZXBvOmZvby9iYXIiLCJhdWQiOiJweXB"
12+
"pIiwicmVmIjoiZmFrZSIsInNoYSI6ImZha2UiLCJyZXBvc2l0b3J5IjoiZm9vL2JhciIsI"
13+
"nJlcG9zaXRvcnlfb3duZXIiOiJmb28iLCJyZXBvc2l0b3J5X293bmVyX2lkIjoiMTIzIiw"
14+
"icnVuX2lkIjoiZmFrZSIsInJ1bl9udW1iZXIiOiJmYWtlIiwicnVuX2F0dGVtcHQiOiIxI"
15+
"iwicmVwb3NpdG9yeV9pZCI6ImZha2UiLCJhY3Rvcl9pZCI6ImZha2UiLCJhY3RvciI6ImZ"
16+
"vbyIsIndvcmtmbG93IjoiZmFrZSIsImhlYWRfcmVmIjoiZmFrZSIsImJhc2VfcmVmIjoiZ"
17+
"mFrZSIsImV2ZW50X25hbWUiOiJmYWtlIiwicmVmX3R5cGUiOiJmYWtlIiwiZW52aXJvbm1"
18+
"lbnQiOiJmYWtlIiwiam9iX3dvcmtmbG93X3JlZiI6ImZvby9iYXIvLmdpdGh1Yi93b3JrZ"
19+
"mxvd3MvZXhhbXBsZS55bWxAZmFrZSIsImlzcyI6Imh0dHBzOi8vdG9rZW4uYWN0aW9ucy5"
20+
"naXRodWJ1c2VyY29udGVudC5jb20iLCJuYmYiOjE2NTA2NjMyNjUsImV4cCI6MTY1MDY2N"
21+
"DE2NSwiaWF0IjoxNjUwNjYzODY1fQ.f-FMv5FF5sdxAWeUilYDt9NoE7Et0vbdNhK32c2o"
22+
"C-E"
23+
)
2424

2525
DUMMY_ACTIVESTATE_OIDC_JWT = (
26-
"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJqdGkiOiI2ZTY3YjFjYi0yYjhkLTRi"
27-
"ZTUtOTFjYi03NTdlZGIyZWM5NzAiLCJzdWIiOiJvcmc6ZmFrZW9yZzpwcm9qZWN0OmZha"
28-
"2Vwcm9qZWN0IiwiYXVkIjoicHlwaSIsImFjdG9yX2lkIjoiZmFrZSIsImFjdG9yIjoiZm"
29-
"9vIiwib3JhZ2FuaXphdGlvbl9pZCI6IjdlNjdiMWNiLTJiOGQtNGJlNS05MWNiLTc1N2V"
30-
"kYjJlYzk3MCIsIm9yZ2FuaXphdGlvbiI6ImZha2VvcmciLCJwcm9qZWN0X3Zpc2liaWxp"
31-
"dHkiOiJwcml2YXRlIiwicHJvamVjdF9pZCI6IjhlNjdiMWNiLTJiOGQtNGJlNS05MWNiL"
32-
"Tc1N2VkYjJlYzk3MCIsInByb2plY3RfcGF0aCI6ImZha2VvcmcvZmFrZXByb2plY3QiLC"
33-
"Jwcm9qZWN0IjoiZmFrZXByb2plY3QiLCJidWlsZGVyIjoicHlwaV9idWlsZGVyIiwiaW5"
34-
"ncmVkaWVudF9uYW1lIjoiZmFrZWluZ3JlZGllbnQiLCJhcnRpZmFjdF9pZCI6IjllNjdi"
35-
"MWNiLTJiOGQtNGJlNS05MWNiLTc1N2VkYjJlYzk3MCIsImlzcyI6Imh0dHBzOi8vcGxhd"
36-
"GZvcm0uYWN0aXZlc3RhdGUuY29tL2FwaS92MS9vYXV0aC9vaWRjIiwibmJmIjoxNjUwNj"
37-
"YzMjY1LCJleHAiOjE2NTA2NjQxNjUsImlhdCI6MTY1MDY2Mzg2NX0.R4q-vWAFXHrBSBK"
38-
"AZuHHIsGOkqlirPxEtLfjLIDiLr0"
39-
)
26+
"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJqdGkiOiI2ZTY3YjFjYi0yYjhkLTRi"
27+
"ZTUtOTFjYi03NTdlZGIyZWM5NzAiLCJzdWIiOiJvcmc6ZmFrZW9yZzpwcm9qZWN0OmZha"
28+
"2Vwcm9qZWN0IiwiYXVkIjoicHlwaSIsImFjdG9yX2lkIjoiZmFrZSIsImFjdG9yIjoiZm"
29+
"9vIiwib3JhZ2FuaXphdGlvbl9pZCI6IjdlNjdiMWNiLTJiOGQtNGJlNS05MWNiLTc1N2V"
30+
"kYjJlYzk3MCIsIm9yZ2FuaXphdGlvbiI6ImZha2VvcmciLCJwcm9qZWN0X3Zpc2liaWxp"
31+
"dHkiOiJwcml2YXRlIiwicHJvamVjdF9pZCI6IjhlNjdiMWNiLTJiOGQtNGJlNS05MWNiL"
32+
"Tc1N2VkYjJlYzk3MCIsInByb2plY3RfcGF0aCI6ImZha2VvcmcvZmFrZXByb2plY3QiLC"
33+
"Jwcm9qZWN0IjoiZmFrZXByb2plY3QiLCJidWlsZGVyIjoicHlwaV9idWlsZGVyIiwiaW5"
34+
"ncmVkaWVudF9uYW1lIjoiZmFrZWluZ3JlZGllbnQiLCJhcnRpZmFjdF9pZCI6IjllNjdi"
35+
"MWNiLTJiOGQtNGJlNS05MWNiLTc1N2VkYjJlYzk3MCIsImlzcyI6Imh0dHBzOi8vcGxhd"
36+
"GZvcm0uYWN0aXZlc3RhdGUuY29tL2FwaS92MS9vYXV0aC9vaWRjIiwibmJmIjoxNjUwNj"
37+
"YzMjY1LCJleHAiOjE2NTA2NjQxNjUsImlhdCI6MTY1MDY2Mzg2NX0.R4q-vWAFXHrBSBK"
38+
"AZuHHIsGOkqlirPxEtLfjLIDiLr0"
39+
)

tests/conftest.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,10 @@
6565
from warehouse.subscriptions import services as subscription_services
6666
from warehouse.subscriptions.interfaces import IBillingService, ISubscriptionService
6767

68+
from .common.constants import REMOTE_ADDR, REMOTE_ADDR_HASHED
6869
from .common.db import Session
6970
from .common.db.accounts import EmailFactory, UserFactory
7071
from .common.db.ip_addresses import IpAddressFactory
71-
from .common.constants import REMOTE_ADDR, REMOTE_ADDR_HASHED
72-
7372

7473
_HERE = Path(__file__).parent.resolve()
7574
_FIXTURES = _HERE / "_fixtures"

tests/unit/accounts/test_forms.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
from warehouse.captcha import recaptcha
3434
from warehouse.events.tags import EventTag
3535
from warehouse.utils.webauthn import AuthenticationRejectedError
36+
3637
from ...common.constants import REMOTE_ADDR
3738

3839

tests/unit/accounts/test_security_policy.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
from warehouse.accounts import UserContext, security_policy
2222
from warehouse.accounts.interfaces import IUserService
2323
from warehouse.utils.security_policy import AuthenticationMethod
24+
2425
from ...common.constants import REMOTE_ADDR
2526

2627

tests/unit/accounts/test_services.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@
4747
from warehouse.metrics import IMetricsService, NullMetrics
4848
from warehouse.rate_limiting.interfaces import IRateLimiter
4949

50+
from ...common.constants import REMOTE_ADDR
5051
from ...common.db.accounts import EmailFactory, UserFactory
5152
from ...common.db.ip_addresses import IpAddressFactory
52-
from ...common.constants import REMOTE_ADDR
5353

5454

5555
class TestDatabaseUserService:

tests/unit/email/test_init.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,10 @@
2424
from warehouse.email.interfaces import IEmailSender
2525
from warehouse.email.services import EmailMessage
2626

27+
from ...common.constants import REMOTE_ADDR
2728
from ...common.db.accounts import EmailFactory, UserFactory
2829
from ...common.db.organizations import TeamFactory
29-
from ...common.constants import REMOTE_ADDR
30+
3031

3132
@pytest.mark.parametrize(
3233
("user", "address", "expected"),

tests/unit/forklift/test_legacy.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@
6666
ReleaseFactory,
6767
RoleFactory,
6868
)
69-
from ...common.constants import REMOTE_ADDR
7069

7170

7271
def _get_tar_testdata(compression_type=""):

tests/unit/manage/test_forms.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
from warehouse.accounts.models import ProhibitedEmailDomain
2323
from warehouse.manage import forms
2424

25-
from ...common.db.packaging import ProjectFactory
2625
from ...common.constants import REMOTE_ADDR
26+
from ...common.db.packaging import ProjectFactory
2727

2828

2929
class TestCreateRoleForm:

tests/unit/oidc/test_views.py

Lines changed: 9 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@
4040
from warehouse.packaging import services
4141
from warehouse.packaging.models import Project
4242
from warehouse.rate_limiting.interfaces import IRateLimiter
43-
from ...common.constants import DUMMY_GITHUB_OIDC_JWT, DUMMY_ACTIVESTATE_OIDC_JWT
43+
44+
from ...common.constants import DUMMY_ACTIVESTATE_OIDC_JWT, DUMMY_GITHUB_OIDC_JWT
4445

4546

4647
def test_ratelimiters():
@@ -192,9 +193,7 @@ def find_service(self, *a, **kw):
192193
assert err["description"] == "malformed JWT"
193194

194195

195-
def test_mint_token_from_oidc_jwt_decode_leaky_exception(
196-
monkeypatch
197-
):
196+
def test_mint_token_from_oidc_jwt_decode_leaky_exception(monkeypatch):
198197
class Request:
199198
def __init__(self):
200199
self.response = pretend.stub(status=None)
@@ -308,8 +307,7 @@ def test_mint_token_from_oidc_creates_expected_service(
308307
assert mint_token.calls == [pretend.call(oidc_service, token, request)]
309308

310309

311-
def test_mint_token_from_trusted_publisher_verify_jwt_signature_fails(
312-
):
310+
def test_mint_token_from_trusted_publisher_verify_jwt_signature_fails():
313311
oidc_service = pretend.stub(
314312
verify_jwt_signature=pretend.call_recorder(lambda token: None),
315313
)
@@ -405,9 +403,7 @@ def find_publishers_mockup(_, pending: bool = False):
405403
}
406404

407405

408-
def test_mint_token_pending_publisher_project_already_exists(
409-
db_request
410-
):
406+
def test_mint_token_pending_publisher_project_already_exists(db_request):
411407
project = ProjectFactory.create()
412408
pending_publisher = PendingGitHubPublisherFactory.create(
413409
project_name=project.name,
@@ -442,10 +438,7 @@ def test_mint_token_pending_publisher_project_already_exists(
442438
assert oidc_service.find_publisher.calls == [pretend.call(claims, pending=True)]
443439

444440

445-
def test_mint_token_from_oidc_pending_publisher_ok(
446-
monkeypatch,
447-
db_request
448-
):
441+
def test_mint_token_from_oidc_pending_publisher_ok(monkeypatch, db_request):
449442
user = UserFactory.create()
450443

451444
pending_publisher = PendingGitHubPublisherFactory.create(
@@ -681,9 +674,7 @@ def find_service(iface, **kw):
681674
]
682675

683676

684-
def test_mint_token_warn_constrain_environment(
685-
monkeypatch, db_request
686-
):
677+
def test_mint_token_warn_constrain_environment(monkeypatch, db_request):
687678
claims_in_token = {"ref": "someref", "sha": "somesha", "environment": "fakeenv"}
688679
claims_input = {"ref": "someref", "sha": "somesha"}
689680
time = pretend.stub(time=pretend.call_recorder(lambda: 0))
@@ -794,10 +785,7 @@ def find_service(iface, **kw):
794785
]
795786

796787

797-
def test_mint_token_with_prohibited_name_fails(
798-
monkeypatch,
799-
db_request
800-
):
788+
def test_mint_token_with_prohibited_name_fails(monkeypatch, db_request):
801789
prohibited_project_name = ProhibitedProjectFactory.create()
802790
user = UserFactory.create()
803791
PendingGitHubPublisherFactory.create(
@@ -836,10 +824,7 @@ def test_mint_token_with_prohibited_name_fails(
836824
)
837825

838826

839-
def test_mint_token_with_invalid_name_fails(
840-
monkeypatch,
841-
db_request
842-
):
827+
def test_mint_token_with_invalid_name_fails(monkeypatch, db_request):
843828
user = UserFactory.create()
844829
pending_publisher = PendingGitHubPublisherFactory.create(
845830
project_name="-foo-",

tests/unit/utils/test_wsgi.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
from warehouse.ip_addresses.models import IpAddress
2222
from warehouse.utils import wsgi
2323

24+
from ...common.constants import REMOTE_ADDR, REMOTE_ADDR_HASHED, REMOTE_ADDR_SALTED
2425
from ...common.db.ip_addresses import IpAddressFactory as DBIpAddressFactory
25-
from ...common.constants import REMOTE_ADDR, REMOTE_ADDR_SALTED, REMOTE_ADDR_HASHED
2626

2727

2828
class TestProxyFixer:
@@ -149,7 +149,10 @@ def test_skips_x_forwarded_when_not_enough(self):
149149
response = pretend.stub()
150150
app = pretend.call_recorder(lambda e, s: response)
151151

152-
environ = {"HTTP_X_FORWARDED_FOR": REMOTE_ADDR, "HTTP_SOME_OTHER_HEADER": "woop"}
152+
environ = {
153+
"HTTP_X_FORWARDED_FOR": REMOTE_ADDR,
154+
"HTTP_SOME_OTHER_HEADER": "woop",
155+
}
153156
start_response = pretend.stub()
154157

155158
resp = wsgi.ProxyFixer(app, token=None, ip_salt=None, num_proxies=2)(

0 commit comments

Comments
 (0)