Refactor known device check into UserService (#19074)

* Refactor known device check into user service

* Update translations

* Remove unused imports

Author: di

tests/unit/accounts/test_services.py

@@ -48,6 +48,7 @@
     EmailFactory,
     UserFactory,
     UserTermsOfServiceEngagementFactory,
+    UserUniqueLoginFactory,
 )
 from ...common.db.ip_addresses import IpAddressFactory
 
@@ -2014,3 +2015,97 @@ def test_factory(self):
 
         assert svc._http is request.http
         assert svc.client_id == "some_client_id"
+
+
+class TestDeviceIsKnown:
+    def test_device_is_known(self, user_service):
+        user = UserFactory.create()
+        UserUniqueLoginFactory.create(
+            user=user, ip_address=REMOTE_ADDR, status="confirmed"
+        )
+        request = pretend.stub(
+            db=user_service.db,
+            remote_addr=REMOTE_ADDR,
+            find_service=lambda *a, **kw: pretend.stub(),
+        )
+        assert user_service.device_is_known(user.id, request)
+
+    def test_device_is_not_known(self, user_service, monkeypatch):
+        user = UserFactory.create(with_verified_primary_email=True)
+        send_email = pretend.call_recorder(lambda *a, **kw: None)
+        monkeypatch.setattr(services, "send_unrecognized_login_email", send_email)
+        token_service = pretend.stub(dumps=lambda d: "fake_token")
+        user_service.request = pretend.stub(
+            db=user_service.db,
+            remote_addr=REMOTE_ADDR,
+            headers={
+                "User-Agent": (
+                    "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:15.0) "
+                    "Gecko/20100101 Firefox/15.0.1"
+                )
+            },
+            find_service=lambda *a, **kw: token_service,
+        )
+
+        assert not user_service.device_is_known(user.id, user_service.request)
+        assert send_email.calls == [
+            pretend.call(
+                user_service.request,
+                user,
+                ip_address=REMOTE_ADDR,
+                user_agent="Firefox (Ubuntu)",
+                token="fake_token",
+            )
+        ]
+
+    def test_device_is_pending_not_expired(self, user_service, monkeypatch):
+        user = UserFactory.create(with_verified_primary_email=True)
+        UserUniqueLoginFactory.create(
+            user=user, ip_address=REMOTE_ADDR, status="pending"
+        )
+        send_email = pretend.call_recorder(lambda *a, **kw: None)
+        monkeypatch.setattr(services, "send_unrecognized_login_email", send_email)
+        token_service = pretend.stub(dumps=lambda d: "fake_token")
+        user_service.request = pretend.stub(
+            db=user_service.db,
+            remote_addr=REMOTE_ADDR,
+            headers={
+                "User-Agent": (
+                    "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:15.0) "
+                    "Gecko/20100101 Firefox/15.0.1"
+                )
+            },
+            find_service=lambda *a, **kw: token_service,
+        )
+
+        assert not user_service.device_is_known(user.id, user_service.request)
+        assert send_email.calls == []
+
+    @pytest.mark.parametrize("ua_string", [None, "no bueno", "Python-urllib/3.7"])
+    def test_device_is_not_known_bad_user_agent(
+        self, user_service, monkeypatch, ua_string
+    ):
+        user = UserFactory.create(with_verified_primary_email=True)
+        send_email = pretend.call_recorder(lambda *a, **kw: None)
+        monkeypatch.setattr(services, "send_unrecognized_login_email", send_email)
+        token_service = pretend.stub(dumps=lambda d: "fake_token")
+        headers = {}
+        if ua_string:
+            headers["User-Agent"] = ua_string
+        user_service.request = pretend.stub(
+            db=user_service.db,
+            remote_addr=REMOTE_ADDR,
+            headers=headers,
+            find_service=lambda *a, **kw: token_service,
+        )
+
+        assert not user_service.device_is_known(user.id, user_service.request)
+        assert send_email.calls == [
+            pretend.call(
+                user_service.request,
+                user,
+                ip_address=REMOTE_ADDR,
+                user_agent=ua_string or "Unknown User-Agent",
+                token="fake_token",
+            )
+        ]