New organization application statuses (#17765)

* (orgs) refactor OrganizationApplication.is_approved to an Enum

* (orgs): update user management view to display org application status

* (orgs admin): update org application list

* (orgs admin): add actions for requestmore/defer application

* (orgs applications) add a basic manage view for pending requests

* (orgs applications): implement request/response tooling for org application information requests

* translations

* (orgs admin) don't require re-auth on admin org routes

* (chore) refactor OrganizationApplicationStatus to an enum.StrEnum

* address notes from code review

NOTE: WAREHOUSE_DOMAIN is not set by default in development, so it will show as "None"

* translations

* drop Organization.date_approved column

vestigal from the Organization -> OrganizationApplication migration.

* suggestions from code review

* translations

Author: ewdurbin

tests/common/db/organizations.py

@@ -15,9 +15,11 @@
 import factory
 import faker
 
+from warehouse.observations.models import ObservationKind
 from warehouse.organizations.models import (
     Organization,
     OrganizationApplication,
+    OrganizationApplicationStatus,
     OrganizationInvitation,
     OrganizationNameCatalog,
     OrganizationProject,
@@ -34,6 +36,7 @@
 
 from .accounts import UserFactory
 from .base import WarehouseFactory
+from .observations import ObserverFactory
 from .packaging import ProjectFactory
 from .subscriptions import StripeCustomerFactory, StripeSubscriptionFactory
 
@@ -50,7 +53,7 @@ class Meta:
     orgtype = "Community"
     link_url = factory.Faker("uri")
     description = factory.Faker("sentence")
-    is_approved = None
+    status = OrganizationApplicationStatus.Submitted
     submitted_by = factory.SubFactory(UserFactory)
     submitted = factory.Faker(
         "date_time_between_dates",
@@ -59,6 +62,24 @@ class Meta:
     )
 
 
+class OrganizationApplicationObservationFactory(WarehouseFactory):
+    class Meta:
+        model = OrganizationApplication.Observation
+
+    related = factory.SubFactory(OrganizationApplicationFactory)
+    related_name = factory.LazyAttribute(lambda o: repr(o.related))
+    observer = factory.SubFactory(ObserverFactory)
+
+    created = factory.Faker(
+        "date_time_between_dates",
+        datetime_start=datetime.datetime(2020, 1, 1),
+        datetime_end=datetime.datetime(2022, 1, 1),
+    )
+    kind = ObservationKind.InformationRequest.value[0]
+    payload = factory.Faker("json")
+    summary = factory.Faker("paragraph")
+
+
 class OrganizationFactory(WarehouseFactory):
     class Meta:
         model = Organization
@@ -79,13 +100,11 @@ def _create(cls, model_class, *args, **kwargs):
     link_url = factory.Faker("uri")
     description = factory.Faker("sentence")
     is_active = True
-    is_approved = None
     created = factory.Faker(
         "date_time_between_dates",
         datetime_start=datetime.datetime(2020, 1, 1),
         datetime_end=datetime.datetime(2022, 1, 1),
     )
-    date_approved = None
 
 
 class OrganizationEventFactory(WarehouseFactory):

tests/common/db/packaging.py

@@ -72,7 +72,6 @@ class Meta:
         "random_element", elements=[kind.value[1] for kind in ObservationKind]
     )
     payload = factory.Faker("json")
-    # TODO: add `observer` field
     summary = factory.Faker("paragraph")
 
 

tests/unit/admin/test_routes.py

@@ -49,6 +49,19 @@ def test_includeme():
             "/admin/organization_applications/{organization_application_id}/approve/",
             domain=warehouse,
         ),
+        pretend.call(
+            "admin.organization_application.requestmoreinfo",
+            (
+                "/admin/organization_applications/{organization_application_id}"
+                "/requestmoreinfo/"
+            ),
+            domain=warehouse,
+        ),
+        pretend.call(
+            "admin.organization_application.defer",
+            "/admin/organization_applications/{organization_application_id}/defer/",
+            domain=warehouse,
+        ),
         pretend.call(
             "admin.organization_application.decline",
             "/admin/organization_applications/{organization_application_id}/decline/",