Skip to content

Commit fca7c00

Browse files
authored
fix: set tab indexes explicitly for form (#18716)
1 parent 2530989 commit fca7c00

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

warehouse/locale/messages.pot

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1140,7 +1140,7 @@ msgid "Sponsors"
11401140
msgstr ""
11411141

11421142
#: warehouse/templates/accounts/login.html:7
1143-
#: warehouse/templates/accounts/login.html:87 warehouse/templates/base.html:44
1143+
#: warehouse/templates/accounts/login.html:90 warehouse/templates/base.html:44
11441144
#: warehouse/templates/base.html:78
11451145
msgid "Log in"
11461146
msgstr ""
@@ -1508,7 +1508,7 @@ msgstr ""
15081508
msgid "Confirm password to continue"
15091509
msgstr ""
15101510

1511-
#: warehouse/templates/accounts/login.html:56
1511+
#: warehouse/templates/accounts/login.html:57
15121512
#: warehouse/templates/accounts/register.html:142
15131513
#: warehouse/templates/accounts/reset-password.html:28
15141514
#: warehouse/templates/manage/manage_base.html:451
@@ -1517,7 +1517,7 @@ msgid "Password"
15171517
msgstr ""
15181518

15191519
#: warehouse/templates/accounts/login.html:34
1520-
#: warehouse/templates/accounts/login.html:58
1520+
#: warehouse/templates/accounts/login.html:59
15211521
#: warehouse/templates/accounts/recovery-code.html:28
15221522
#: warehouse/templates/accounts/register.html:69
15231523
#: warehouse/templates/accounts/register.html:91
@@ -1603,18 +1603,18 @@ msgstr ""
16031603
msgid "(required)"
16041604
msgstr ""
16051605

1606-
#: warehouse/templates/accounts/login.html:69
1606+
#: warehouse/templates/accounts/login.html:71
16071607
#: warehouse/templates/re-auth.html:55
16081608
msgid "Your password"
16091609
msgstr ""
16101610

1611-
#: warehouse/templates/accounts/login.html:66
1611+
#: warehouse/templates/accounts/login.html:68
16121612
#: warehouse/templates/manage/manage_base.html:457
16131613
#: warehouse/templates/re-auth.html:82
16141614
msgid "Show password"
16151615
msgstr ""
16161616

1617-
#: warehouse/templates/accounts/login.html:91
1617+
#: warehouse/templates/accounts/login.html:95
16181618
#: warehouse/templates/re-auth.html:86
16191619
msgid "Forgot password?"
16201620
msgstr ""

warehouse/templates/accounts/login.html

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ <h1 class="page-title">{% trans title=title %}Log in to {{ title }}{% endtrans %
4141
required="required",
4242
class_="form-group__field",
4343
aria_describedby="username-errors",
44+
tabindex="1",
4445
) }}
4546
<div id="username-errors">
4647
{% if form.username.errors %}
@@ -62,7 +63,8 @@ <h1 class="page-title">{% trans title=title %}Log in to {{ title }}{% endtrans %
6263
<input data-action="change->password#togglePasswords"
6364
data-password-target="showPassword"
6465
id="show-password"
65-
type="checkbox">
66+
type="checkbox"
67+
tabindex="3">
6668
&nbsp;{% trans %}Show password{% endtrans %}
6769
</label>
6870
</div>
@@ -72,6 +74,7 @@ <h1 class="page-title">{% trans title=title %}Log in to {{ title }}{% endtrans %
7274
autocomplete="current-password",
7375
spellcheck="false", data_password_target="password",
7476
aria_describedby="password-errors",
77+
tabindex="2",
7578
) }}
7679
<div id="password-errors">
7780
{% if form.password.errors %}
@@ -85,7 +88,8 @@ <h1 class="page-title">{% trans title=title %}Log in to {{ title }}{% endtrans %
8588
<div>
8689
<input type="submit"
8790
value="{% trans %}Log in{% endtrans %}"
88-
class="button button--primary">
91+
class="button button--primary"
92+
tabindex="4">
8993
</div>
9094
<span>
9195
<a href="{{ request.route_url('accounts.request-password-reset') }}">{% trans %}Forgot password?{% endtrans %}</a>

0 commit comments

Comments
 (0)