Bugfix: Avoid creating duplicate conventional generators by setting keep_existing_capacities to false (pypsa-meets-earth#1630)

* Bugfix: Avoid creating duplicate conventional generators by setting  to

Co-authored-by: sophiabrl <sophialunor@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add relase_notes

* minor fixes, using older syntax for PyPSA

* bugfix in add_brownfield: remove assets if name already exist in the new network

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: sophiabrl <sophialunor@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ekaterina <e.v.kasilova@gmail.com>
Co-authored-by: Yerbol Akhmetov <113768325+yerbol-akhmetov@users.noreply.github.com>

Author: 5 people

config.default.yaml

@@ -749,11 +749,12 @@ sector:
 
   conventional_generation: # generator : carrier
     OCGT: gas
+    CCGT: gas
     oil: oil
     coal: coal
     lignite: lignite
     biomass: biomass
-  keep_existing_capacities: true
+  keep_existing_capacities: false
 
 solving:
   options:

doc/release_notes.rst

@@ -40,6 +40,8 @@ This part of documentation collects descriptive release notes to capture the mai
 
 **Minor Changes and bug-fixing**
 
+* Avoid creating duplicate conventional generators by setting `keep_existing_capacities` to `false`. Convert CCGT as links in `prepare_sector_network` `PR #1630 <https://github.com/pypsa-meets-earth/pypsa-earth/pull/1630>`__
+
 * Refine load shedding capacity calculation to use bus-specific maximum loads instead of fixed large values, improving solver performance and numeric stability. Rename load shedding generator carrier to 'load shedding' (now) instead of just 'load' (previously) `PR #1581 <https://github.com/pypsa-meets-earth/pypsa-earth/pull/1581>`__
 
 * The configuration setting for ``focus_weights`` has been moved from ``focus_weights:`` to ``cluster_options: focus_weights:``. Backwards compatibility to old config files is maintained `PR #1565 <https://github.com/pypsa-meets-earth/pypsa-earth/pull/1565>`__

scripts/add_brownfield.py

@@ -73,6 +73,9 @@ def add_brownfield(n, n_p, year):
         c.df[f"{attr}_nom"] = c.df[f"{attr}_nom_opt"]
         c.df[f"{attr}_nom_extendable"] = False
 
+        # remove assets if name already exist in the new network
+        n_p.mremove(c.name, c.df.index.intersection(getattr(n, c.list_name).index))
+
         n.import_components_from_dataframe(c.df, c.name)
 
         # copy time-dependent

scripts/prepare_sector_network.py

@@ -112,7 +112,7 @@ def add_generation(
     # Not required, because nodes are already defined in "nodes"
     # nodes = pop_layout.index
 
-    fallback = {"OCGT": "gas"}
+    fallback = {"OCGT": "gas", "CCGT": "gas"}
     conventionals = options.get("conventional_generation", fallback)
 
     for generator, carrier in conventionals.items():
@@ -157,6 +157,12 @@ def add_generation(
             lifetime=costs.at[generator, "lifetime"],
         )
 
+        # remove newly added links that have no capacity and are not extendable
+        to_remove = n.links.query(
+            "carrier == @carrier & p_nom == 0 & not p_nom_extendable"
+        ).index
+        n.mremove("Link", to_remove)
+
         # set the "co2_emissions" of the carrier to 0, as emissions are accounted by link efficiency separately (efficiency to 'co2 atmosphere' bus)
         n.carriers.loc[carrier, "co2_emissions"] = 0