Skip to content

Commit 4fe714c

Browse files
more codecheck cleans
1 parent 55902e1 commit 4fe714c

File tree

8 files changed

+23
-9
lines changed

8 files changed

+23
-9
lines changed

pyrepl/unix_eventqueue.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ def insert(self, event):
100100
self.events.append(event)
101101

102102
def push(self, char):
103-
self.buf.append(char)
103+
self.buf.append(ord(char))
104104
if char in self.k:
105105
if self.k is self.ck:
106106
#sanity check, buffer is empty when a special key comes

testing/infrastructure.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,15 @@
2121
from pyrepl.reader import Reader
2222
from pyrepl.console import Console, Event
2323

24+
2425
class EqualsAnything(object):
2526
def __eq__(self, other):
2627
return True
28+
29+
2730
EA = EqualsAnything()
2831

32+
2933
class TestConsole(Console):
3034
height = 24
3135
width = 80
@@ -38,7 +42,7 @@ def __init__(self, events, verbose=False):
3842

3943
def refresh(self, screen, xy):
4044
if self.next_screen is not None:
41-
assert screen == self.next_screen, "[ %s != %s after %r ]"%(
45+
assert screen == self.next_screen, "[ %s != %s after %r ]" % (
4246
screen, self.next_screen, self.last_event_name)
4347

4448
def get_event(self, block=1):

testing/test_basic.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,23 +24,27 @@ def test_basic():
2424
read_spec([(('self-insert', 'a'), ['a']),
2525
( 'accept', ['a'])])
2626

27+
2728
def test_repeat():
2829
read_spec([(('digit-arg', '3'), ['']),
2930
(('self-insert', 'a'), ['aaa']),
3031
( 'accept', ['aaa'])])
3132

33+
3234
def test_kill_line():
3335
read_spec([(('self-insert', 'abc'), ['abc']),
3436
( 'left', None),
3537
( 'kill-line', ['ab']),
3638
( 'accept', ['ab'])])
3739

40+
3841
def test_unix_line_discard():
3942
read_spec([(('self-insert', 'abc'), ['abc']),
4043
( 'left', None),
4144
( 'unix-word-rubout', ['c']),
4245
( 'accept', ['c'])])
4346

47+
4448
def test_kill_word():
4549
read_spec([(('self-insert', 'ab cd'), ['ab cd']),
4650
( 'beginning-of-line', ['ab cd']),

testing/test_bugs.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,17 @@
2525

2626
import pytest
2727

28+
2829
class HistoricalTestReader(HistoricalReader, TestReader):
2930
pass
3031

32+
3133
@pytest.mark.xfail(reason='event missing', run=False)
3234
def test_transpose_at_start():
33-
read_spec([( 'transpose', [EA, '']),
34-
( 'accept', [''])])
35+
read_spec([
36+
('transpose', [EA, '']),
37+
('accept', [''])])
38+
3539

3640
def test_cmd_instantiation_crash():
3741
spec = [

testing/test_functional.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import pytest
77
import sys
88

9+
910
def pytest_funcarg__child(request):
1011
try:
1112
pexpect = pytest.importorskip('pexpect')
@@ -17,8 +18,8 @@ def pytest_funcarg__child(request):
1718
child.sendline('main()')
1819
return child
1920

21+
2022
def test_basic(child):
2123
child.sendline('a = 3')
2224
child.sendline('a')
2325
child.expect('3')
24-

testing/test_keymap.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import pytest
21
from pyrepl.keymap import compile_keymap
32

43

testing/test_readline.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
from pyrepl.readline import _ReadlineWrapper
2-
import os, pty
2+
import os
3+
import pty
4+
35

46
def test_raw_input():
57
readline_wrapper = _ReadlineWrapper()
68
master, slave = pty.openpty()
79
readline_wrapper.f_in = slave
8-
os.write(master, 'input\n')
10+
os.write(master, b'input\n')
911
result = readline_wrapper.raw_input('prompt:')
1012
assert result == 'input'
1113
# A bytes string on python2, a unicode string on python3.

testing/test_unix_reader.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from __future__ import unicode_literals
22
from pyrepl.unix_eventqueue import EncodedQueue
33

4+
45
def test_simple():
56
q = EncodedQueue({}, 'utf-8')
67

@@ -13,4 +14,3 @@ def test_simple():
1314
assert q.get() is None
1415
assert event.data == a
1516
assert event.raw == b
16-

0 commit comments

Comments
 (0)